Better way of filling vector in smartPointer exercise (!19) · Merge requests · Sebastien Ponce / CplusplusCourse - outdated · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Sebastien Ponce requested to merge sponce_smartVectorFix into master 4 years ago

All threads resolved!

@bgruber what do you think of this fix ? Avoids to use the reset, and optimizes the object creation by removing even the move operations.

Activity

Bernhard Manfred Gruber @bgruber started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Sebastien Ponce
Last reply by Sebastien Ponce 4 years ago

Sebastien Ponce added 5 commits 4 years ago

added 5 commits

37902191...d36ae97a - 4 commits from branch master
12774445 - Better way of filling vector in smartPointer exercise

Compare with previous version

Sebastien Ponce resolved all threads 4 years ago

resolved all threads

Sebastien Ponce @sponce · 4 years ago

Author Owner

ok, shall I merge this version ? By the way I've dropped the message about "we have a memory leak" in the solution as we solved it :-)

Bernhard Manfred Gruber @bgruber · 4 years ago

Contributor

Looks good to me!

Sebastien Ponce mentioned in commit 4 years ago

mentioned in commit dc66d7c2

Sebastien Ponce merged 4 years ago

merged

Please register or sign in to reply