Johannes Junggeburth authored 3 years ago and Frank Winklmeier committed 3 years ago

MuonTrackPerformance - reindendation & MuonTruthAlgs: Reject creation of TruthSegements from LF muons only

William Axel Leight authored 4 years ago and Adam Edward Barton committed 4 years ago

The final MuonSegmentContainer is now produced in the MuonCreatorAlg, so in serial mode the MuonSegmentTruthAssociationAlg has to run after that.
This fix just moves the configuration of the algorithm to ensure that this is the case.

These only made sense in the separate MuonCalibConfig.py. Remove them from here.
Fixes ATLASRECTS-5848.

This reverts commit 4f37164b

These only made sense in the separate MuonCalibConfig.py. Remove them from here.
Fixes ATLASRECTS-5848.

Applied changes according to rlangenb/athena!2 (diffs) for MuonSegmentRegionRecoveryTool. TrackingGeometrySvc to CondAlg migration (ATLASRECTS-5694)

Edward Moyse authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

I think the one in MuonRecExample can be removed, so this is my attempt to do that
The functions were moved muon MuonCnvExample, into the MuonCalibConfig file there.

 - print function
 - relative module import
 - coerce iterator to list

William Axel Leight authored 5 years ago and Frank Winklmeier committed 5 years ago

The service now uses the MdtCondDbData object created by the MdtCondDbAlg, rather than the MdtCondSummarySvc.
The MdtIntersectGeometry objects are no longer cached in the service but created on the fly as needed, making the service much simpler.
Mutable data members are removed or made local variables.
The MdtCondDbData object and the MuonDetectorManager must now be passed in from outside: the clients of the service are adjusted accordingly.
The MdtCondDbAlg must now run during muon reconstruction: the configuration is updated accordingly.

William Axel Leight authored 5 years ago and Frank Winklmeier committed 5 years ago

Changes to the ParticleCaloExtensionTool configuration broke muon standalone running: this allows it to run again by configuring MCTruthClassifier to not use that tool.
(It shouldn't be necessary for this purpose so it should be safe to remove it.)

If the NSW is being used, the MuonTruthDecorationAlg should include MM and sTGC SDOs.

Forgot to do this in previous MR !15011.  Also adjusted the configuration accordingly.


Former-commit-id: 73b3a87f

Neither the MuonTrackTruthTool nor the MuonDetailedTrackTruthMaker were using NSW truth hits.
For the MuonDetailedTrackTruthMaker, an NSW flag was added to determine whether to load the NSW hits or the CSC hits.
For the MuonTrackTruthTool, it proved easier (and more compatible with the new framework) to move the retrieval of objects from SG to the algorithms calling it.
Thus the MuonTrackPerformanceAlg and MuonSegmentTruthAssociationAlg now retrieve the necessary collections, using an NSW flag to determine what hits to load.
The MuonTrackTruthTool and its interfaces are also updated accordingly.
Finallly, the configuration of the algorithms is adjusted to ensure that the NSW flag is set correctly.


Former-commit-id: a45c3847f59fac1fc2473745b112613c649219f6

James Beacham authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Set the barcode offset for MCTruthClassifier

See merge request atlas/athena!8421

(cherry picked from commit 19b399ec [formerly ad2741abb29f9b9e37664ba71f0fb4492558b289])

825a0071 Set the barcode offset for MCTruthClassifier

Former-commit-id: 465ed5ad

This fix ensures that barcode shifts for the MuonTruthDecorationAlg, MuonTruthAssociationAlg, and MuonSegmentTruthAssociationAlg are correctly set in the configuration.
This resolves some of the muon issues reported in the validation of the MC18 truth strategy (see ATLPHYSVAL-553 for more details), owing to that strategy using different barcode shifts.
It also helps to address longstanding problems with muon truth matching not being barcode-independent (see ATLASRECTS-2962 for more details).
This manual sweep resolves conflicts in the original sweep from 21.0 to master.


Former-commit-id: 8450ad17

	* Disable MS vertexing when MS standalone reco is disabled.
	* tagging MuonRecExample-03-00-03

2015-09-25 Edward.Moyse@cern.ch
	* doMSVertex is True by default in MuonRec
	* tagging MuonRecExample-03-00-02

2015-08-25 Niels van Eldik
	* disable MDT segment finding in NCB segment finder
	* fix bug in configuration of Hough transform for collisions
	* tagging MuonRecExample-03-00-01

2015-08-21 Edward.Moyse@cern.ch
	* Fix for MuonRec_myTopOptions.py - remove reference to removed file

2015-08-19 Edward.Moyse@cern.ch
        * Merged back changes from devbranches/MuonRecExample-NCB

2015-08-12 Niels van Eldik
	* major clean-up of the configuration
...
(Long ChangeLog diff - truncated)

	* fix for saving the MS vertex output in xAOD
	* tagging MuonRecExample-02-05-79

2014-12-17 Andrea Coccaro <Andrea.Coccaro AT cern.ch
	* setting the doMSVertex flag to True only when needed
	* tagging MuonRecExample-02-05-78

2014-12-10  Massimiliano Bellomo  <massimiliano.bellomo@cern.ch>
	* python/MuonRecTools.py fix in MuonParticleCreatorTool to use new perigee expression option. Now set to "Origin".
	* tagging MuonRecExample-02-05-77

2014-12-04  Massimiliano Bellomo  <massimiliano.bellomo@cern.ch>
	* MuonRecOutputItemList_jobOptions.py renaming of xAOD::PrepRawData to xAOD::TrackMeasurementValidation
	* tagging MuonRecExample-02-05-76

2014-12-01 Niels van Eldik
	* small fix
	* tagging MuonRecExample-02-05-75

2014-12-01 Niels van Eldik
...
(Long ChangeLog diff - truncated)