Mark Hodgkinson authored 4 years ago and Adam Edward Barton committed 4 years ago

Test to run once per week on Mondays.

Matthew Thomas Anthony authored 4 years ago and Adam Edward Barton committed 4 years ago

Added relevant class components for FE histogram filling. Compiles, but is not necessarily correct runtime at present

correction (ATLASRECTS-5763)

In TauClusterFinder, we retrieve the orignal cluster via a decorated
link. However, if there is no vertex correction in jet reconstruction, then the
returned original cluster will be nullptr, which result in a crash.

To fix this, we retrieve the orignal cluster only when jet performs
vertex correction.

In addition, a flag of SkipNegativeEnergy is added to control the
removal of cluster with rawE <= 0

Root math library is called MathCore, not Math.

Savanna Shaw authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Passing the event context to the data handles used in the CscSegmentUtilTool (ATR-22181):
- Update the chain of tools/algorithms that lead to the CscSegmentUtilTool to pass the event context
- removing the CscSegmentMaker, since it isn't used anymore so it doesn't need to be updated
- The updates to the inside out/stau reco tools are just enough to get the other changes on the segment finding side working (eventually the event context should be passed also to the data handles used by these tools).

In TauAxisSetter, a tool named TauVertexCorrection is used to perform
the vertex correction. As this tool will soon be removed, we move the
related implementation to TauAxisSetter.

Fixes crash with q220.

Gabriel Facini authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Tracks passing a selection designed to identify photon conversions were
given a shortcut through the ambi for a small efficiency gain. This had
the unwanted side-effect of allowing electron brem tracks (mostly in the
forward direction) to have incorrect hits and overshare IBL hits
lowering the EM LH identification rate.

Simple fix - remove short cut
Impact on digest - 3 tracks over 3 events

Delete obsolete RTT-based job options and other obsolete scripts.

Missing import of TriggerFlags.

Hello,

This MR is just downgrading a few WARNING to DEBUG. It concerns a feature in the tau reconstruction we need to clarify.

Cheers,
Bertrand

allowing calculation of TRT eProbabilityNN for all egamma GSF tracks by setting default pT cut-off to 0

Xiaozhong Huang authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

For Topo seed jets, the cluster links in the tau candidate point to the
clusters in a shallow copy container, which will not be available in AOD
of R22. To fix this, the cluster links point to the cluster in the
original container.

For PFlow seed jets, the cluster links in the tau candidate point to the
PFOs(neutral or charged). It is confusing. Now the cluster links point
to the corresponding cluter in the PFO object.

Previously, only clusters within 0.2 cone of tau candidate is stored. In
the tau reconstruction, we need all the clusters. Thus the cut of dR is now
removed.

The clusters could have energy <=0, which will be skimmed in AOD. The
link then becomes invalid. Since we do not want an invalid link, all
the clusters are requied to have positive energy.

Cleanup cmake configuration and enable flake8. Also delete obsolete RTT
test configuration and reference file.

LArCellRecalibration uses the old / unsafe tool ILArADC2MeVTool.
However, LArCellRecalibration is not actually used anymore, so just
get rid of it.