Skip to content
Snippets Groups Projects
  1. Aug 06, 2021
    • Frank Winklmeier's avatar
      RPC_CondCabling: avoid expensive copies of SectorLogicSetup · 8f8402a6
      Frank Winklmeier authored
      `RpcCablingCondAlg` was accidentally making copies of the huge
      `SectorLogicSetup` class. Make sure to use references and move
      semantics. This speeds up the creation of the conditions by a
      factor ~2.5 (e.g. number `malloc`s are reduced from 11M to 3M).
      
      To avoid future problems, make the class move-only as we don't really
      need to make copies.
      8f8402a6
  2. Aug 05, 2021
  3. Aug 04, 2021
  4. Aug 03, 2021
  5. Aug 02, 2021
    • Frank Winklmeier's avatar
      TrigT1RPChardware: remove DISP_ macros · e240c882
      Frank Winklmeier authored
      Replace the usage of `DISP` macros as appropriate:
        - pass `MsgStream` for useful messages
        - plain `cout` for standalone/validation code
        - `throw` exception for fatal errors
        - comment code if only needed for debugging
      
      Also delete methods that were marked as obsolete.
      
      Relates to ATLASRECTS-6313.
      e240c882
  6. Jul 30, 2021
  7. Jul 27, 2021
  8. Jul 26, 2021
    • Frank Winklmeier's avatar
      RPC_CondCabling: optimize and cleanup CMAprogram · 31230200
      Frank Winklmeier authored
      Several cleanups and optimizations for `CMAprogram`:
      - move member initialization to header file
      - re-arrange data-members to reduce padding (checked with `pahole`)
      - use delegating constructors to reduce copy&paste
      - use compiler-generated copy constructor and assignment (not clear why
        these were hand-written and i.e. the now obsolete `copy_threshold` was a
        terribly slow implementation of an array copy)
      - replace hand-written loops over arrays with `std::fill_n` (in C++20
        this may even turn into a `constexpr`)
      - replace "union-gymnastics" to initialize `m_trig_edge_reg` and
        `m_pipe_*` members with hard-coded values
      
      This significantly reduces the time spent building the cabling in
      `RpcCablingCondAlg` (callgrind showed a hotspot in `copy_threshold`).
      
      In passing cleanup cmake dependencies.
      
      Relates to ATLASRECTS-1068.
      31230200
    • Minlin Wu's avatar
      MuonPRDTest: Add TGC and CSC PRDVariables · b741e989
      Minlin Wu authored and Frank Winklmeier's avatar Frank Winklmeier committed
      b741e989
    • Michela Biglietti's avatar
      adding drift time summary histograms · da1f36f2
      Michela Biglietti authored
      da1f36f2
  9. Jul 21, 2021
  10. Jul 20, 2021
  11. Jul 19, 2021
  12. Jul 18, 2021
  13. Jul 17, 2021
  14. Jul 16, 2021
  15. Jul 15, 2021
Loading