Skip to content
Snippets Groups Projects
  1. Jan 03, 2020
  2. Oct 25, 2019
  3. Oct 18, 2019
  4. Oct 16, 2019
  5. Oct 14, 2019
  6. Aug 04, 2019
    • John Derek Chapman's avatar
      Make PixelDigitization respond to digitizationFlags.doInDetNoise · 74e8a3a6
      John Derek Chapman authored and Walter Lampl's avatar Walter Lampl committed
      This commit adds an `m_doNoise` configurable property to the
      `FrontEndSimTool` base class. This is used to determine whether
      or not the `ThermalNoise(...)` and `RandomNoise(...)` functions
      should be called in the derived classes. This should replicate
      the behaviour in `21.0` where the `PixelNoisyCellGenerator` is
      only used when `digitizationFlags.doInDetNoise()==True`.
      74e8a3a6
  7. Jun 25, 2019
  8. Jun 11, 2019
  9. Apr 16, 2019
  10. Apr 12, 2019
  11. Mar 10, 2019
  12. Mar 04, 2019
  13. Jan 11, 2019
  14. Dec 05, 2018
  15. Nov 20, 2018
  16. Nov 04, 2018
  17. Jul 20, 2018
  18. Jul 06, 2018
  19. Mar 09, 2018
    • Jochen Meyer's avatar
      extract common geometry config from InDetGMJobProperties · 08f242c4
      Jochen Meyer authored
      The common geometry configuration stored in the Oracle table
      "AtlasCommon" can only be accessed via InDetGMJobProperties as it
      is implemented as properties of GeometryFlags which is member of
      InDetGMFlags. Because the properties are (mostly) general (like
      the run period) they should not be part of the ID only, but really
      "common". It is already bad enough that the only specific field
      in the table is called "STRIPGEOTYPE" ... On top, it turned out
      that InDetGMJobProperties.py and LArGMJobProperties.py are quite
      carbon copies of each other. These flaws are addressed in the
      implementation of CommonGMJobProperties.py which provides access
      to the common properties. Secondly it serves as base-class for the
      classes in InDetGMJobProperties.py/LArGMJobProperties.py to reduce
      code duplication. The modification is purely technical and should
      not change anything. It passes the Tier0 tests. All clients should
      be adjusted, but it was not possible to find test jobs for all of
      them.
      
      
      Former-commit-id: c79918fa
      08f242c4
  20. Dec 11, 2017
  21. Dec 08, 2017
  22. Nov 20, 2017
    • Soshi Tsuno's avatar
      cleanup · 1974788c
      Soshi Tsuno authored
      Former-commit-id: 1ee19443aa07106f068713d7a2db5e18ef3bf294
      1974788c
  23. Jul 04, 2017
  24. Jul 03, 2017
  25. Jun 30, 2017
  26. Jun 29, 2017
  27. Jun 28, 2017
  28. Apr 17, 2017
  29. Apr 11, 2017
  30. Mar 08, 2017
  31. Mar 03, 2017
  32. Mar 01, 2017
  33. Feb 22, 2017
  34. Feb 21, 2017
    • Soshi Tsuno's avatar
      fix coverity defect (PixelDigitization-02-03-30) · 3de8c5a1
      Soshi Tsuno authored
        * Fix coverity defect.
      	* Tagged as PixelDigitization-02-03-30.
      
      2017-02-10  Soshi Tsuno
        * Add front-end simulation tool.
        * Delete PixelCellDiscriminator. Now this functionality is done in front-end sim tool.
      	* Tagged as PixelDigitization-02-03-29.
      
      
      Former-commit-id: e12aa8ed
      3de8c5a1
  35. Feb 15, 2017
    • Soshi Tsuno's avatar
      small bug fix and remove warnings (PixelDigitization-02-03-28) · e1b4a986
      Soshi Tsuno authored
        * Small bug fix and remove warnings.
      	* Tagged as PixelDigitization-02-03-28.
      
      2017-01-30  Soshi Tsuno
        * Recover processBunchXing method for ATLASSIM-2900.
      	* Tagged as PixelDigitization-02-03-27.
      
      2016-12-26  Soshi Tsuno
        * The PixelDigitizationTool was largely cleaned up.
        * This is the preparation step toward ver.-03-00-00.
      	* Tagged as PixelDigitization-02-03-26.
      
      2016-12-25  Soshi Tsuno
        * remove SpecialPixelGenerator.
      	* Tagged as PixelDigitization-02-03-25.
      
      2016-12-21  Soshi Tsuno
        * Use ToolHandleArray for charge simulation (SurfaceChargeTool)
        * remove SurfaceChargeTool
      	* Tagged as PixelDigitization-02-03-24.
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: c9bf8664
      e1b4a986
  36. Jan 01, 2017
  37. Nov 26, 2016
    • Alejandro Alonso Diaz's avatar
      ATLASRECTS-3738 fix (PixelDigitization-02-03-22) · d0eb6ed6
      Alejandro Alonso Diaz authored
      	* Fixing Random Genenrators for Bichsel model: ATLASRECTS-3738
      	* Tagging PixelDigitization-02-03-22.
      
      2016-11-19  scott snyder  <snyder@bnl.gov>
      	* Tagging PixelDigitization-02-03-21.
      	* endreq -> endmsg.
      
      2016-11-17  John Chapman  <John.Chapman@cern.ch>
      
      	* python/PixelDigitizationConfig.py (PixelOverlayDigitizationTool):
      	Specify output StorGate instance for RDOCollNameSPM. ATLASSIM-3026
      	* Tagged as PixelDigitization-02-03-20
      
      2016-11-02  John Chapman  <John.Chapman@cern.ch>
      	* python/PixelDigitizationConfig.py (PixelOverlayDigitizationTool):
      	Specify output StoreGate instance in RDOCollName and SDOCollName
      	properties - necessary now that these are configuring
      	WriteHandles. obo Tatyana Kharlamova. ATLASSIM-3026
      	* Taggged as PixelDigitization-02-03-19
      
      
      Former-commit-id: 0ce3ed2d
      d0eb6ed6
  38. Sep 28, 2016
    • Qi Zeng's avatar
      Bug fix for ATLPHYSVAL-430; Tagging PixelDigitization-02-03-18 (PixelDigitization-02-03-18) · 59ec3881
      Qi Zeng authored
        * bug fix : ATLPHYSVAL-430
        * Update SurfaceChargesTool to avoid initialization failure with Bichsel model on
        * Update PixelDigitizationConfig for fast version of Bichsel model
        * Tagged as PixelDigitization-02-03-18
      
      2016-08-25 Soshi Tsuno
        * bug fix : ATLASRECTS-3444
        * Correct IBL configuration for 2016.
      
      
      Former-commit-id: 8c1d238c806e9684017d395b7c1382ca715ed82b
      59ec3881
  39. Jul 02, 2016
    • Soshi Tsuno's avatar
      update the job option to match with 2016 pixel operation (PixelDigitization-02-03-15) · e66488d2
      Soshi Tsuno authored
        * Changed the pixel setting to match with 2016 operation.
      	* Tagged as PixelDigitization-02-03-15
      
      2016-06-23 Fares Djama
              * Fix Jira ticket ATLASRECTS-3262 (fix cmt/requirement file)
      	* Tagged as PixelDigitization-02-03-14
      
      2016-06-23 Fares Djama
              * Fix Jira ticket ATLASRECTS-3294: get rid of hard coded limit in jumping over ganged pixels in FE-I3
      	* Tagged as PixelDigitization-02-03-13
      
      2016-06-23 Fares Djama
              * Fix Jira ticket ATLASRECTS-2925
              * Fix a bug in Initialization method of PixelNoisyGenerator
      	* Tagged as PixelDigitization-02-03-12
      
      2016-06-17 Fares Djama
              * Fixed the decoding of noisy map from pixid to (chip,col,row):
      	*   1) IBL Compatible
      	*   2) Uses a new decodePixelID method in PixelCoralClientUtils-00-05-09 to avoid hard coding
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: e1673344
      e66488d2
  40. Jun 14, 2016
    • John Derek Chapman's avatar
      src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx: revert change from... · c0423f14
      John Derek Chapman authored
      src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx: revert change from PixelDigitization-02-03-08 which switched processBunchXing back to using PileUpEventInfo rather than xAOD::EventInfo. Fix initialization order warning. PixelNoisyCellGenerator no longer needs to be a member variable. Fix issue where chargedDiodes variable name was both a member variable and an input variable name to a method. python/PixelDigitizationConfig.py (BasicPixelDigitizationTool): no need to specifically add to the ToolSvc. CfgGetter will take care of this. ATLASSIM-2565. Tagged as PixelDigitization-02-03-09 (PixelDigitization-02-03-09)
      
      	* src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx:
      	revert change from PixelDigitization-02-03-08 which switched
      	processBunchXing back to using PileUpEventInfo rather than
      	xAOD::EventInfo. Fix initialization order
      	warning. PixelNoisyCellGenerator no longer needs to be a member
      	variable. Fix issue where chargedDiodes variable name was both a
      	member variable and an input variable name to a method.
      	* python/PixelDigitizationConfig.py (BasicPixelDigitizationTool):
      	no need to specifically add to the ToolSvc. CfgGetter will take
      	care of this. ATLASSIM-2565
      	* Tagged as PixelDigitization-02-03-09
      
      2016-05-30 Sam Meehan
        * tagged revision 749595 as PixelDigitization-02-03-08
      
      2016-05-27 Sam Meehan
        * tagged revision 749595 as PixelDigitization-02-03-07
      
      2016-05-13 Soshi Tsuno
      ...
      (Long ChangeLog diff - truncated)
      
      
      Former-commit-id: d9bb100a
      c0423f14
Loading