Goetz Gaycken authored 4 years ago and Adam Edward Barton committed 4 years ago

By toggling a flag the TrackingGeometry conditions data is used instead of
the TrackingGeometrySvc in the Navigator.

Enable flake8 and make code compliant. Most of this code is legacy and
where the fixes would have been too numerous/intrusive mark the entire
file with `noqa`. Also delete unused `EFIDUtils.py`.

Don't use `is' with string literal.

- remove the pixel covariance correction,
- remove dRmap based identification of collimated tracks,
- remove creation of dRmap.

All of the above is unused and was not properly migrated to athenaMT.

There are a few remaining configuration scripts that do not get used
by q431 but which we should still migrate to use the new boundary
checking tool. This commit adapts those files to use the new tool,
often creating a new tool for it and using that in lieu of the old
configuration parameters.

- print function.
- also fix use of exec, has_key, and argument destructuring.

Anthony Morley authored 5 years ago and Walter Lampl committed 5 years ago

Clean up logic in GSF extrapolator  --  still needs some work but this is a little less verbose and confusing

Goetz Gaycken authored 5 years ago and Walter Lampl committed 5 years ago

- Use a PRD-to-track map rather than the PRD_AssociationTool which conains a PRD-to-track map
  internally. This is needed to resolve ATLASRECTS-5005.
- Made all methods const.
- The score processor does not create track copies anymore, thus PRD-to-track maps stay valid for
  scored tracks.
- The ambiguity processors now use a helper class which manages the new and original tracks i.e.
  tracks with mixed ownership, and creates track copies only for the final track collection if
  necessary.
- Moved debug ntuple code of simple ambiguity processor to a new derived class, to improve the
  readability.

- provide methods to create fitters with all its tools which use customized pixel cluster
on track tools with configurable split cluster maps, and
- use these methods to create fitters for extended track collections, which require
different split cluster maps.

This fixes q223, which requires a special split cluster map for pixel tracks.

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Drop PixelDetectorManager from PixelClusterization and remove UsePixelDetectorManager = True from configuration

global replacement 'PixelNnClusterNnCondAlg'-> 'PixelClusterNnCondAlg' and 'PixelNnClusterNnWithTrackCondAlg' -> 'PixelClusterNnWithTrackCondAlg' to fix ATLASRECTS-5013

It fixes the errors in  ATR-19928.

The actual hole search is performed by the ID helper tool. The only
purpose of the tool was to toogle the ID hole search on or off.
The latter is now handled by a boolean property as is the case
for muons.

- Added conditions algorithm to created TTrainedNetworks,
- whcich are accessed by the NnClusterizationFactory via
  CondHandles (replacing the conditions callbacks).


Former-commit-id: b38a3bdc

Former-commit-id: 04d0b0124ffbefc5b42290961365e64db61926de