Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T ttbbRun2Bamboo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sebastien Wertz
  • ttbbRun2Bamboo
  • Merge requests
  • !34

Several bugfixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Wertz requested to merge severalFixes into master Mar 31, 2021
  • Overview 1
  • Commits 3
  • Changes 3

Fix bug reported by @kcormier and better handle the processing of several samples interactively (in case of both data and MC being processed).

This goes together with the bugfixes to bamboo here (not merged yet): cp3-cms/bamboo!183 (merged)

The bug reported by @kcormier came from bamboo: for producing yields tables, bamboo creates special histograms, but these have no systematic variations produced (yet). However, there was already code in place for reading and using variation histograms (with __SYST suffix) if they were present in the output files, which is where the bug was present. Since we manually copy histograms produced in systematic variation samples into the nominal sample output file, adding a __SYST suffix, this triggered the crash. The bug in bamboo is fixed, but we also now skip the copy of those special histograms when postprocessing alternative samples, since it doesn't make sense to include only those uncertainties in the yields tables.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: severalFixes