Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
C
calypso
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Eric Torrence
calypso
Commits
a6bddfc6
Commit
a6bddfc6
authored
5 months ago
by
Xiaocong Ai
Committed by
FASER Reco
2 months ago
Browse files
Options
Downloads
Patches
Plain Diff
report WARNINT for re-fit failure
parent
20bb53a1
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
+3
-3
3 additions, 3 deletions
Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
+8
-5
8 additions, 5 deletions
Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
with
11 additions
and
8 deletions
Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
+
3
−
3
View file @
a6bddfc6
...
...
@@ -252,11 +252,11 @@ StatusCode CKF2::execute() {
ATH_MSG_WARNING
(
"No fitted parameters at target position"
<<
targetZposition
);
}
std
::
unique_ptr
<
Trk
::
Track
>
trk
=
m_createTrkTrackTool
->
createTrack
(
gctx
,
track
,
fittedParams
,
m_backwardPropagation
);
std
::
unique_ptr
<
Trk
::
Track
>
trk
=
std
::
move
(
m_createTrkTrackTool
->
createTrack
(
gctx
,
track
,
fittedParams
,
m_backwardPropagation
)
)
;
m_numberOfSelectedTracks
++
;
//@todo: make the KF refit configurable
std
::
unique_ptr
<
Trk
::
Track
>
trk2
=
m_kalmanFitterTool1
->
fit
(
ctx
,
gctx
,
trk
.
get
(),
Acts
::
BoundVector
::
Zero
(),
m_isMC
);
std
::
unique_ptr
<
Trk
::
Track
>
trk2
=
std
::
move
(
m_kalmanFitterTool1
->
fit
(
ctx
,
gctx
,
trk
.
get
(),
Acts
::
BoundVector
::
Zero
(),
m_isMC
)
)
;
if
(
trk2
!=
nullptr
)
{
outputTracks
->
push_back
(
std
::
move
(
trk2
));
}
else
{
...
...
This diff is collapsed.
Click to expand it.
Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
+
8
−
5
View file @
a6bddfc6
...
...
@@ -346,12 +346,12 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx
std
::
unique_ptr
<
Trk
::
Track
>
newTrack
=
nullptr
;
if
(
!
inputTrack
->
measurementsOnTrack
()
||
inputTrack
->
measurementsOnTrack
()
->
size
()
<
m_minMeasurements
)
{
ATH_MSG_
DEBU
G
(
"Input track has
no or too little
measurements and cannot be fitted"
);
ATH_MSG_
WARNIN
G
(
"Input track has
only "
<<
inputTrack
->
measurementsOnTrack
()
->
size
()
<<
"
measurements and cannot be fitted"
);
return
nullptr
;
}
if
(
!
inputTrack
->
trackParameters
()
||
inputTrack
->
trackParameters
()
->
empty
())
{
ATH_MSG_
DEBU
G
(
"Input track has no track parameters and cannot be fitted"
);
ATH_MSG_
WARNIN
G
(
"Input track has no track parameters and cannot be fitted"
);
return
nullptr
;
}
...
...
@@ -420,8 +420,11 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx
//} else {
// ATH_MSG_DEBUG("No fitted parameters for track");
//}
newTrack
=
m_createTrkTrackTool
->
createTrack
(
gctx
,
track
);
}
newTrack
=
std
::
move
(
m_createTrkTrackTool
->
createTrack
(
gctx
,
track
));
}
else
{
ATH_MSG_WARNING
(
"Fit failed for parameters starting at "
<<
trackParameters
.
position
(
gctx
).
transpose
()
<<
" and "
<<
actsSls
.
size
()
<<
" measurements with error"
<<
result
.
error
());
}
if
(
m_statesWriter
&&
!
m_noDiagnostics
)
{
StatusCode
statusStatesWriterTool
=
m_trajectoryStatesWriterTool
->
write
(
gctx
,
tracks
,
isMC
);
...
...
@@ -430,7 +433,7 @@ KalmanFitterTool::fit(const EventContext &ctx, const Acts::GeometryContext &gctx
StatusCode
statusSummaryWriterTool
=
m_trajectorySummaryWriterTool
->
write
(
gctx
,
tracks
,
isMC
);
}
return
newTrack
;
return
std
::
move
(
newTrack
)
;
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment