Resolve "Remove hardcoding of language switcher in Mega Menu"
Closes #43 (closed)
Merge request reports
Activity
changed milestone to %External Partner October 2019
1617 1617 clear: both; 1618 1618 } 1619 1619 } 1620 1621 .region-header > section:first-child { -
@kplatis I had to apply this rule in order to fix the alignment of the Mega Menu. Without it (so in the current dev branch actually) the menu is centered and not right aligned as it should be. Also, without it, the alignment with the language chooser is broken.
@pgroeger I just tried it with this rule applied and still it is centered and the LS is broken. Did you clear the registry after applying it?
Edited by Konstantinos Platis-
@kplatis Yes I did. Can you send me the environment where you tested it? And also could you please specify what you mean by 'LS is broken'? I understand that something affects the language switcher but I don't know what you mean by broken. When I tested it, it worked for me.
-
@kplatis I set up a complete fresh testing env (
test-pgr-dev) and tested my solution again. For a clean installation it works fine.... In fact I investigated a bit further and found styling and js code in cernclean which belongs to the language switcher.How should I proceed? Should I copy the styling and js logic from cernclean to cernpublic or should I remove the code from the themes entirely and include it in the component?
-
@pgroeger Can you please mention the stylings that you found in cernclean if they are not many? Or at least some of them... You can post the links referencing the lines where you find them
Edited by Konstantinos Platis -
@kplatis As far as I remember it were these lines, which are missing in CERNPUBLIC: https://gitlab.cern.ch/web-team/drupal/public/d8/themes/cern/blob/master/sass/layout.scss#L379
Closed as part of a systematic review of old, open issues. As Drupal 8 is no longer supported, open issues should be directed to the corresponding Drupal 9 version. Kindly note, however, that many issues reported on Drupal 8 repositories have been addressed as part of the migration to Drupal 9.
