Re-introduce readinessProbe for eoscredentials

As per !55 (comment 7245825)

Also avoid whitespace at end of lines when using nindent

No need for a MR in okd4-install IMO, this can wait for deployment with the next significant change to webeos-deployment

el9/templates/deployment.yaml

@@ -52,7 +52,7 @@ spec:
         app: {{ .Release.Name | quote }}
         webeos.cern.ch/place-new-webeos-sites: {{ .Values.placeNewWebeosSites | quote }}
         {{- if .Values.podLabels }}
-        {{ .Values.podLabels | toYaml | nindent 8 }}
+        {{- .Values.podLabels | toYaml | nindent 8 }}
         {{- end }}
       annotations:
         webeos.cern.ch/webeos-site-path-regex: {{ .Values.webeosSitePathRegex | quote }}
@@ -65,13 +65,13 @@ spec:
         checksum/mailrc-config: {{ include (print $.Template.BasePath "/mailrc-configmap.yaml") . | sha256sum }}
     spec:
       {{- if .Values.nodeSelector }}
-      nodeSelector: {{ .Values.nodeSelector | toYaml | nindent 8 }}
+      nodeSelector: {{- .Values.nodeSelector | toYaml | nindent 8 }}
       {{- end }}
       {{- if .Values.tolerations }}
-      tolerations: {{ .Values.tolerations | toYaml | nindent 8 }}
+      tolerations: {{- .Values.tolerations | toYaml | nindent 8 }}
       {{- end }}
       {{- if .Values.affinity }}
-      affinity: {{ .Values.affinity | toYaml | nindent 8 }}
+      affinity: {{- .Values.affinity | toYaml | nindent 8 }}
       {{- end }}
       dnsPolicy: ClusterFirst
       # This is required to make sure DNS resolution doesn't time out.
@@ -112,13 +112,13 @@ spec:
           - name: RELOAD_TIMESTAMP_FILE
             value: /etc/httpd/conf.d/vhost/httpd-config-loaded
           {{- if .Values.containers.httpd.livenessProbe }}
-          livenessProbe: {{ .Values.containers.httpd.livenessProbe | toYaml | nindent 12 }}
+          livenessProbe: {{- .Values.containers.httpd.livenessProbe | toYaml | nindent 12 }}
           {{- end }}
           {{- if .Values.containers.httpd.readinessProbe }}
-          readinessProbe: {{ .Values.containers.httpd.readinessProbe | toYaml | nindent 12 }}
+          readinessProbe: {{- .Values.containers.httpd.readinessProbe | toYaml | nindent 12 }}
           {{- end }}
           {{- if .Values.containers.httpd.resources }}
-          resources: {{ .Values.containers.httpd.resources | toYaml | nindent 12 }}
+          resources: {{- .Values.containers.httpd.resources | toYaml | nindent 12 }}
           {{- end }}
           lifecycle:
             preStop:
@@ -166,13 +166,13 @@ spec:
           imagePullPolicy: Always
           command: ["php-fpm"]
           {{- if .Values.containers.phpFpm.livenessProbe }}
-          livenessProbe: {{ .Values.containers.phpFpm.livenessProbe | toYaml | nindent 12 }}
+          livenessProbe: {{- .Values.containers.phpFpm.livenessProbe | toYaml | nindent 12 }}
           {{- end }}
           {{- if .Values.containers.phpFpm.readinessProbe }}
-          readinessProbe: {{ .Values.containers.phpFpm.readinessProbe | toYaml | nindent 12 }}
+          readinessProbe: {{- .Values.containers.phpFpm.readinessProbe | toYaml | nindent 12 }}
           {{- end }}
           {{- if .Values.containers.phpFpm.resources }}
-          resources: {{ .Values.containers.phpFpm.resources | toYaml | nindent 12 }}
+          resources: {{- .Values.containers.phpFpm.resources | toYaml | nindent 12 }}
           {{- end }}
           terminationMessagePath:  /dev/termination-log
           volumeMounts:
@@ -202,10 +202,13 @@ spec:
           image: {{ .Values.containers.eoscredentials.image | quote }}
           imagePullPolicy: Always
           {{- if .Values.containers.eoscredentials.livenessProbe }}
-          livenessProbe: {{ .Values.containers.eoscredentials.livenessProbe | toYaml | nindent 12 }}
+          livenessProbe: {{- .Values.containers.eoscredentials.livenessProbe | toYaml | nindent 12 }}
+          {{- end }}
+          {{- if .Values.containers.eoscredentials.readinessProbe }}
+          readinessProbe: {{- .Values.containers.eoscredentials.readinessProbe | toYaml | nindent 12 }}
           {{- end }}
           {{- if .Values.containers.eoscredentials.resources }}
-          resources: {{ .Values.containers.eoscredentials.resources | toYaml | nindent 12 }}
+          resources: {{- .Values.containers.eoscredentials.resources | toYaml | nindent 12 }}
           {{- end }}
           env:
           - name: KEYTAB_USER
@@ -268,7 +271,7 @@ spec:
             timeoutSeconds: 5
             periodSeconds: 10
             successThreshold: 1
-          resources: {{ .Values.containers.controller.resources | toYaml | nindent 12 }}
+          resources: {{- .Values.containers.controller.resources | toYaml | nindent 12 }}
           securityContext:
             # The config controller must run as root so the generated vhost files can be made readable to root only.
             runAsUser: 0