Draft: Add support for audio, video, and svg files

assigned to @jyde

marked this merge request as draft

added 1 commit

7f6462fa - Move client_max_body_size to nginx.conf

Compare with previous version

Hi Joachim, was this tested locally?

added 1 commit

1aba1c6e - Simplify dramatically

Compare with previous version

resolved all threads

Discard the above comments, @crdeoliv: I realised that we are already including mime.types (only missing support for .wav, which I have now added). Similarly, .svg is included here as well. However, the reason why this is not actually working, I think, is because we are setting server_name as localhost. However, the request to upload anything is coming to website-name.<web/webtest>.cern.ch.

This means that server_name is not matching and makes nginx use the default limit of 1MB.

... one possible option is to match any .cern.ch subdomain or .cern domain (plus localhost...?)

server {
    listen 80;
    server_name *.cern.ch *.cern localhost;
}

I suppose we could then also explicitly reject non-CERN domains with the wildcard... but maybe that is on OpenShift?

added 5 commits

1aba1c6e...8ec36128 - 4 commits from branch mvp
03473f8e - Merge branch 'mvp' into 'multimedia-and-svg-support'

Compare with previous version

Hi Joachim, I included support to video and sound - as you well identified we had to set higher upload limits. I went with your suggestion of 50MB.

In regards to SVG, I suggest we move this into an issue separately. This is a new feature we're introducing - from a quick research online SVG is disabled by default on WordPress due to the security risks. And there's a few ways we can go about it, we might want to introduce a plugin to sanitize svgs automatically for example.

See for reference: !103 (diffs) We still need to apply these changes into theme lite

After some test with https://web-team-test-site-3.webtest.cern.ch we find some bugs related to: !101

The following files cannot be uploaded: .aac , .wav , .flac
The server responded with a status of 413 (Request Entity Too Large) (not related to the size of the file)

it seems like the request body is too long

file used for testing:

flac-example.flac

Checking the deployment, these are the supported files in mime.types:

$ cat /etc/nginx/mime.types

types {
    text/html                                        html htm shtml;
    text/css                                         css;
    text/xml                                         xml;
    image/gif                                        gif;
    image/jpeg                                       jpeg jpg;
    application/javascript                           js;
    application/atom+xml                             atom;
    application/rss+xml                              rss;

    text/mathml                                      mml;
    text/plain                                       txt;
    text/vnd.sun.j2me.app-descriptor                 jad;
    text/vnd.wap.wml                                 wml;
    text/x-component                                 htc;

    image/avif                                       avif;
    image/png                                        png;
    image/svg+xml                                    svg svgz;
    image/tiff                                       tif tiff;
    image/vnd.wap.wbmp                               wbmp;
    image/webp                                       webp;
    image/x-icon                                     ico;
    image/x-jng                                      jng;
    image/x-ms-bmp                                   bmp;

    font/woff                                        woff;
    font/woff2                                       woff2;

    application/java-archive                         jar war ear;
    application/json                                 json;
    application/mac-binhex40                         hqx;
    application/msword                               doc;
    application/pdf                                  pdf;
    application/postscript                           ps eps ai;
    application/rtf                                  rtf;
    application/vnd.apple.mpegurl                    m3u8;
    application/vnd.google-earth.kml+xml             kml;
    application/vnd.google-earth.kmz                 kmz;
    application/vnd.ms-excel                         xls;
    application/vnd.ms-fontobject                    eot;
    application/vnd.ms-powerpoint                    ppt;
    application/vnd.oasis.opendocument.graphics      odg;
    application/vnd.oasis.opendocument.presentation  odp;
    application/vnd.oasis.opendocument.spreadsheet   ods;
    application/vnd.oasis.opendocument.text          odt;
    application/vnd.openxmlformats-officedocument.presentationml.presentation
                                                     pptx;
    application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
                                                     xlsx;
    application/vnd.openxmlformats-officedocument.wordprocessingml.document
                                                     docx;
    application/vnd.wap.wmlc                         wmlc;
    application/wasm                                 wasm;
    application/x-7z-compressed                      7z;
    application/x-cocoa                              cco;
    application/x-java-archive-diff                  jardiff;
    application/x-java-jnlp-file                     jnlp;
    application/x-makeself                           run;
    application/x-perl                               pl pm;
    application/x-pilot                              prc pdb;
    application/x-rar-compressed                     rar;
    application/x-redhat-package-manager             rpm;
    application/x-sea                                sea;
    application/x-shockwave-flash                    swf;
    application/x-stuffit                            sit;
    application/x-tcl                                tcl tk;
    application/x-x509-ca-cert                       der pem crt;
    application/x-xpinstall                          xpi;
    application/xhtml+xml                            xhtml;
    application/xspf+xml                             xspf;
    application/zip                                  zip;

    application/octet-stream                         bin exe dll;
    application/octet-stream                         deb;
    application/octet-stream                         dmg;
    application/octet-stream                         iso img;
    application/octet-stream                         msi msp msm;

    audio/midi                                       mid midi kar;
    audio/mpeg                                       mp3;
    audio/ogg                                        ogg;
    audio/x-m4a                                      m4a;
    audio/x-realaudio                                ra;

    video/3gpp                                       3gpp 3gp;
    video/mp2t                                       ts;
    video/mp4                                        mp4;
    video/mpeg                                       mpeg mpg;
    video/quicktime                                  mov;
    video/webm                                       webm;
    video/x-flv                                      flv;
    video/x-m4v                                      m4v;
    video/x-mng                                      mng;
    video/x-ms-asf                                   asx asf;
    video/x-ms-wmv                                   wmv;
    video/x-msvideo                                  avi;
}

added IT label

Draft: Add support for audio, video, and svg files

Merge request reports

Activity