Skip to content
Snippets Groups Projects
  1. Jun 07, 2018
  2. May 12, 2018
    • Marcelo Vogel's avatar
      Removed dependency on zip binary from Archiving transform (ATLASJT-296) · e0c4fedf
      Marcelo Vogel authored
      Given that the zip binary may not be available at all grid sites, this
      branch replaces the zip binary from the back-end of the Archiving
      transform with python's native zip capability. It can handle ZIP files
      that use the ZIP64 extensions, that is ZIP files that are more than
      4 GByte in size
      
      
      Former-commit-id: 6d177b697cbcbd981a948f5ab30b115d87cd4097
      e0c4fedf
  3. May 05, 2018
    • Marcelo Vogel's avatar
      Fix for Merge_tf.py in AthDerivation · 9da3dc16
      Marcelo Vogel authored
      The python modules in SimuJobTransforms are not available in
      AthDerivation, and Merge_tf crashes while attempting to import
      them for its HITSMerge substep. This branch makes the import
      of these modules conditional to their availability in the release
      
      
      Former-commit-id: 4557e6035658e3db7f09ef700a837936a91f7a03
      9da3dc16
  4. Apr 23, 2018
  5. Apr 22, 2018
  6. Apr 20, 2018
  7. Apr 19, 2018
  8. Apr 12, 2018
  9. Apr 09, 2018
    • Umesh Worlikar's avatar
      ATLASJT-363: Reformat Code, Remove unused variable "maxDiff" · a3bf95fd
      Umesh Worlikar authored
      Former-commit-id: 3e40b830a733bf49794e14d40c736b0fa65877b7
      a3bf95fd
    • Umesh Worlikar's avatar
      ATLASJT-363: Fix bug, JobReport doubles dbDataTotal and dbTimeTotal · ae590e81
      Umesh Worlikar authored
      The implementation of trfJobReport, had assumption of generating one
      jobReport per job. This is not valid on grid jobs, since a text report
      is automatically generated by default in addition to JSON report.
      This caused summing of dbTime and dbTotal, each time a report is
      generated. This fix separates logic for report data generation from
      that of report output for each format. The data dictionary is generated
      only once and reused for each report format. The fix eliminates
      the assumption of one report per job.
      
      
      Former-commit-id: de0586891b691be8dbedfc187dc2be89527bef31
      ae590e81
    • Umesh Worlikar's avatar
      ATLASJT-363: Add debug message while running in non-interactive mode · 32c5277f
      Umesh Worlikar authored
      For jobs running on grid, PyJobTransforms detects the non-interactive
      environment and enables text report. The debug message would help
      detecting potential issues on grid jobs which otherwise would be
      difficult to reproduce in interactive mode.
      
      
      Former-commit-id: 43b31f69c027fff8120c241c154dc00774ff0bd3
      32c5277f
  10. Mar 22, 2018
    • Marcelo Vogel's avatar
      Transform support for Event Service (ATLASJT-379) · b23e275b
      Marcelo Vogel authored
      This branch provides support for activating the Event Service mode
      of AthenaMP for general transforms, specifically in reconstruction.
      It also updates the support to simulation transforms by refactoring
      the existing code.
      
      
      Former-commit-id: 8695d7f118345e1c2e6ea3c753df0991aea283db
      b23e275b
  11. Mar 20, 2018
    • Graeme A Stewart's avatar
      Remove deprecated simplejson module · 99659a77
      Graeme A Stewart authored
      simplejson was an extra module required for very old python versions
      (<2.6). It is now present in all python versions actively used
      as the "json" module.
      
      
      Former-commit-id: c80ebbc2dba16674017e4510a229c6ec169698aa
      99659a77
  12. Feb 28, 2018
  13. Feb 27, 2018
  14. Feb 21, 2018
    • Zach Marshall's avatar
      Updates to output options · 3d42ef70
      Zach Marshall authored
      Ensuring that stopped particle TRs can be written alone (without a hit
      file), and that we can filter TRs
      
      
      Former-commit-id: f032c5b899765db73b1db487632cd712e1c768d6
      3d42ef70
  15. Jan 16, 2018
  16. Nov 15, 2017
    • Marcelo Vogel's avatar
      This branch fixes the incorrect parsing of the job's log file (ATLASJT-371) · 18c62e54
      Marcelo Vogel authored
      This branch fixes the incorrect parsing of service names from a sub-step's
      log file during log file validation. Long service names are sometimes
      listed in the job summary section of the log file without a space
      between the name and the character '|'. Before the fix the log parser
      was identifying these lines from the summary as additional errors. With
      the fix in this branch the parser ignores such lines.
      
      
      Former-commit-id: a7d5cc4313ddaa11ff788ec1c75f689027124443
      18c62e54
  17. Oct 16, 2017
  18. Oct 14, 2017
  19. Sep 08, 2017
    • Umesh Worlikar's avatar
      Fix: PyJobTransform misses logfile errors containing substep names [ATLASJT-370] · 595009af
      Umesh Worlikar authored
      trfValidation.py, trfUtils.py, trfExe.py:
      Provide an option in trfUtils such that callers can request substep
      names to be removed from log lines, before parsing.
      The presence of substep name 'in some log files', caused log scanner
      to skip those lines since the log scaner simply looks for standard log
      pattern SERVICE-LEVEL-MESSAGE.
      With this update, scan behavior becomes independent of presence
      (or absence) of substep names in log files.
      
      test_trfValidation.py:
      Add unit tests for log scan with Serial and MP use cases.
      
      
      Former-commit-id: 9cf03f23a9801288a695764ab7e407d2bbf51319
      595009af
  20. Sep 01, 2017
  21. Aug 29, 2017
    • Marcelo Vogel's avatar
      This branch fixes a bug in PyJobTransforms' archiveExecutor (ATLASG-1285) · 4b7dd43b
      Marcelo Vogel authored
      The introduction of a constructor method (__init__) in
      archiveExecutor was not backward compatible with an implementation of
      archiveExecutor in PATJobTransforms. In this branch the constructor
      is deleted and its intended functionality is implemented in a way that
      makes the constructor backward compatible
      
      
      Former-commit-id: d060494c3b150f74e4594a4ac84b960d4691f00b
      4b7dd43b
  22. Aug 07, 2017
    • Umesh Worlikar's avatar
      Fixed inconsistent log scan results. [ATLASJT-358] · 7d1e0647
      Umesh Worlikar authored
      Fix the typo in function call of LogScanExecutor
      
      Redefine timestamp charactor list to include charactors from timestamps
      added by AthenaMP. The inconsistency in log scan results was due to
      different timestamp formats in log files generated by serial jobs
      and AthenaMP jobs. That additional timestamp in case of AthenaMP is
      a debug feature. AthenaMP adds it during concatenation of worker logs.
      
      Add unit test to validate correct worst error, when the log file
      contains a combination of two time stamps as described above.
      
      
      Former-commit-id: e5ae683f2a661435bf39cbfaa6a695d36f1c0428
      7d1e0647
  23. Aug 01, 2017
    • Marcelo Vogel's avatar
      Transforms support for Shared Writer (ATLASJT-369) · 60c0cce8
      Marcelo Vogel authored
      This branch provides support for handling the output of AthenaMP in sharedWriter
      mode. AthenaMP typically produces an output file per core, which are then merged
      after processing. However, in sharedWriter mode, AthenaMP produces a single output
      file and no merging is necessary. A new argument flag was added (--sharedWriter True)
      to instruct the transforms to properly handle the single output file.
      
      
      Former-commit-id: c3e85a35c7b09fbc7b864910198d08bf0e6c1988
      60c0cce8
  24. Jul 18, 2017
    • Marcelo Vogel's avatar
      Fix athenaMP outputs when ATHENA_PROC_NUMBER=1 (ATLASJT-365) · 1528d75c
      Marcelo Vogel authored
      This brach fixes the output of athenaMP when this is activated with
      only one processor. In this particular case, an output file with the
      correct name was not produced. The single-core worker output was
      symlinked correctly in the top directory, but it was not self merged
      (or moved) and renamed to the output file name provided by the
      user. In this branch, it was chosen to move the single worker output
      file to the top directory and rename it with the output file name
      given as an argument to the transform.
      
      
      Former-commit-id: 4a427bfb3063401c7ee219009ae9844302d2fb44
      1528d75c
  25. Jun 28, 2017
    • Marcelo Vogel's avatar
      Zip or tar multiple small outputs with Archive_tf.py (ATLASJT-296) · b68fb66c
      Marcelo Vogel authored
      The functionality of Archive_tf.py has been expanded, not only
      to archive files into a tar format (with or without compression),
      but also to zip files. This functionality was requested by ADC to
      manage large numbers of small outputs, which need to be stored for
      metadata purposes. The extended functionality allows to zip together
      the small output files before storage.
      
      
      Former-commit-id: 24d16b6ef51f5a04ac23c3adebaeac5ff5f08dbe
      b68fb66c
  26. Jun 22, 2017
  27. Jun 15, 2017
  28. May 19, 2017
  29. May 06, 2017
    • Umesh Worlikar's avatar
      Add time reporting info in JobReport. [ATLASJT-291] · c012f281
      Umesh Worlikar authored
      The time reporting info includes cpu and wall times used during
      transformSetup, inFileValidation, outFileValidation, and
      reportGeneration.
      All time values which were integers in earlier versions of jobReport,
      are now reported as floating point values rounded to 3 decimal places.
      Move utility methods calcCpuTime & calcWallTime from trfExe to trfUtils.
      
      
      Former-commit-id: 7c036b7f41b370f82b3e322859c6321c6e6ac5df
      c012f281
Loading