Change default of "named" attribute to keep compatibility with existing supported Run4 Geo tags

Following discussion on #43 this is a change that should allow compatibility with current Run4 Geometry tags to be maintained.

However, as discussed in the issue, it may be preferred that this goes in a patch branch, and a patch release made. If so, such a branch would need to be created in GeoModelDev/GeoModel so that I can switch to use that as the target branch (I don't have permissions to create it) - the assumption in this MR is that 4.3.2 would be tagged from the master branch, and the patch branch created from that. Any other option would require some additional changes to be added (which is also possible).

The idea would be that in future geometry tags, we will add the named attribute explicitly wherever it is needed, and make a new Run4 geometry tag which can hopefully be used to digitize/reconstruct HITS produced with our current tag, so that they can still be used for most purposes. At that point we will no longer need patched releases, but we will need some time to bridge that gap.

Adding for comment @boudreau @dellacqu @mbandier @rbianchi

and for information @tadej @npetters @jmasik @sroe

Nick, what is your preference? Patch an older release? Or wait till we tag a new release (should happen this week) and then create a patch release from that for your use?

I would prefer to wait for the release and put a special tag on top of that for you. But it introduces a little delay.

Actually I don't care that much. Whatever you like.

I'd be happy to go for the options of waiting for a new tag and then creating a patch release from that. Others included here may want to comment though too on their preference.

Hi Nick,

I agree with the solution you propose. I'd wait for the new tag that should possibly be released this week or early next week. Cheers, Marilena

Sorry for the back-and-forward on this. See !150 (merged) for an alternative which seemed preferable. I'll close this one for now.

mentioned in merge request !150 (merged)

closed