CMake Fix, master branch (2020.11.09.)
Undid the modification from 8d895119. As that one is breaking the build of the project as soon as SQLite is not coming from /usr.
But @rbianchi, please speak up why you made that commit last week... With it reversed, I can build the code with a "cleaned up" version of atlas/atlasexternals!745 (merged) successfully. So we should figure out what it is that prevents you from building the code with this configuration. As this is definitely the correct configuration.
Merge request reports
Activity
added 1 commit
- 9cc2da44 - Disabled the documentation deployment for forks of the repository.
11 11 12 12 # Set up the library. 13 13 add_library( GeoModelDBManager SHARED ${HEADERS} ${SOURCES} ) 14 target_link_libraries( GeoModelDBManager PRIVATE SQLite::SQLite3 ) 14 target_link_libraries( GeoModelDBManager PUBLIC SQLite::SQLite3 ) -
Hi @akraszna , I answered your question about this here:
As I said, a public dependency to SQLite is not needed, and was set by me by mistake in the beginning, actually.
Also, with a public dependency all packages using GeoModel should also find SQlite, but that's not needed because SQLite is only used by the implementation of GeoModelDBManager and no SQLite code is exposed in its public API.
So then what about these lines?
- https://gitlab.cern.ch/GeoModelDev/GeoModel/-/blob/master/GeoModelIO/GeoModelDBManager/GeoModelDBManager/GMDBManager.h#L8
- https://gitlab.cern.ch/GeoModelDev/GeoModel/-/blob/master/GeoModelIO/GeoModelDBManager/GeoModelDBManager/GMDBManager.h#L260
This is as public of a dependency as it gets...
mentioned in merge request !23 (merged)
-
This is not relevant anymore because of !23 (merged), but the issue I pointed out in !23 (merged) still needs to be fixed...