GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption, please take a look at our documentation.

Aleksandra Mnich requested to merge SIGMON-176_13kA into dev Nov 16, 2022

Context

story: https://its.cern.ch/jira/browse/SIGMON-176
task: https://its.cern.ch/jira/browse/SIGMON-458
lhc-sm-api ME: LHCData/lhc-sm-api!219 (merged)

What was done

class for the analysis of the digital signal written
the notebook to demonstrate: https://cernbox.cern.ch/s/hQawxDDeqhfVCHe

TODO

validation ongoing (tests will be updated accordingly)

QA

http://sonar/dashboard?branch=SIGMON-176_13kA&id=lhc-sm-ee
code was unit tested
acceptance tests were written

Review objectives

? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing