Aleksandra Mnich requested to merge SIGMON-176_13kA into dev Nov 16, 2022

Context

story: https://its.cern.ch/jira/browse/SIGMON-176
task: https://its.cern.ch/jira/browse/SIGMON-458
lhc-sm-api ME: LHCData/lhc-sm-api!219 (merged)

What was done

class for the analysis of the digital signal written
the notebook to demonstrate: https://cernbox.cern.ch/s/hQawxDDeqhfVCHe

TODO

validation ongoing (tests will be updated accordingly)

QA

http://sonar/dashboard?branch=SIGMON-176_13kA&id=lhc-sm-ee
code was unit tested
acceptance tests were written

Review objectives

? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing