[SIGMON-299] Backwards compatible QueryBuilder
Context
- Main goal of the task was to reimplement
QueryBuilder
usinglhcsmapi.api.query
to validate the latter - task: https://its.cern.ch/jira/browse/SIGMON-299
-
lhc-sm-api
MR: lhc-sm-api!160 (merged)
What was done
- since functions from
query.py
unpack the single df, in certain places[0]
was removed - calls to the functions that query and analyse 'pc events' were adapted to the new signatures
- references were adapted manually (log messages were fixed, new messages were added, old ones removed)
- HTML reports were replaced
TODO
- integrate with https://its.cern.ch/jira/browse/SIGMON-341
- deal with the
SettingWithCopyException
in https://its.cern.ch/jira/browse/SIGMON-342
QA
- notebooks are passing:
Review objectives
- ? assessment of code functionality
- ? assessment of code quality
- ? identifying potential refactorings / logic common to other projects
- ? knowledge sharing
- ? getting help to understand a piece of code
Edited by Aleksandra Mnich