Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • lhc-sm-hwc lhc-sm-hwc
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCData
  • lhc-sm-hwclhc-sm-hwc
  • Merge requests
  • !14

SIGMON-53 adapt all notebooks to refactoring

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thibaud Marie Eric Buffet requested to merge dev into master Apr 30, 2021
  • Overview 0
  • Commits 4
  • Pipelines 4
  • Changes 19

Context

  • Project(s) README(s) link(s)
  • Story reminder
  • Task details
  • ? other related reviews
  • ? are superseded reviews closed?

What was done

  • keypoints of the implementation / code changes
  • why was this solution preferred over another?
  • ? what could be improved on?

TODO

  • ? Anything still to be done?

QA

  • template link to sonar issues:http://sonar/component_issues/index?id=_GROUP_%3A_ARTIFACT_#resolved%3Dfalse%7Cauthors%3D_PAIR1_%2C_PAIR2_
  • code was unit tested | was not unit tested, because...
  • acceptance tests were written | not written, because...

Review objectives

  • ? assessment of code functionality
  • ? assessment of code quality
  • ? identifying potential refactorings / logic common to other projects
  • ? knowledge sharing
  • ? getting help to understand a piece of code
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev