Merged Thibaud Marie Eric Buffet requested to merge dev into master Apr 30, 2021

Context

Project(s) README(s) link(s)
Story reminder
Task details
? other related reviews
? are superseded reviews closed?

What was done

keypoints of the implementation / code changes
why was this solution preferred over another?
? what could be improved on?

TODO

? Anything still to be done?

QA

template link to sonar issues:http://sonar/component_issues/index?id=_GROUP_%3A_ARTIFACT_#resolved%3Dfalse%7Cauthors%3D_PAIR1_%2C_PAIR2_
code was unit tested | was not unit tested, because...
acceptance tests were written | not written, because...

Review objectives

? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing
? getting help to understand a piece of code