Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
lhc-sm-hwc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LHCData
lhc-sm-hwc
Merge requests
!14
SIGMON-53
adapt all notebooks to refactoring
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
SIGMON-53
adapt all notebooks to refactoring
dev
into
master
Overview
0
Commits
4
Pipelines
4
Changes
19
Merged
Thibaud Marie Eric Buffet
requested to merge
dev
into
master
4 years ago
Overview
0
Commits
4
Pipelines
4
Changes
19
Expand
Context
Project(s) README(s) link(s)
Story reminder
Task details
? other related reviews
? are superseded reviews closed?
What was done
keypoints of the implementation / code changes
why was this solution preferred over another?
? what could be improved on?
TODO
? Anything still to be done?
QA
template link to sonar issues:
http://sonar/component_issues/index?id=_GROUP_%3A_ARTIFACT_#resolved%3Dfalse%7Cauthors%3D_PAIR1_%2C_PAIR2
_
code was unit tested | was not unit tested, because...
acceptance tests were written | not written, because...
Review objectives
? assessment of code functionality
? assessment of code quality
? identifying potential refactorings / logic common to other projects
? knowledge sharing
? getting help to understand a piece of code
0
0
Merge request reports
Loading