Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
lhc-sm-hwc
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Iterations
Wiki
Requirements
Jira
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LHCData
lhc-sm-hwc
Merge requests
!157
[
SIGMON-530
] fix NB_FPA notebook
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Simon Mazenoux
requested to merge
SIGMON-530_fix_AN_RB_FPA_notebook
into
dev
1 year ago
Overview
1
Commits
1
Pipelines
7
Changes
1
Expand
Context
Zinur spotted some bugs in the RB_FPA notebook when neither nQPS is dumped nor logs present in NXCALS.
What was done
add some nullity conditions
TODO
fix the second error in 8.3
QA
code was not unit tested, because we can quickly run the notebook to reproduce the issue and make sure the code was actually fixed
acceptance tests were written
Review objectives
code functionality
code quality
👍
0
👎
0
Merge request reports
Activity
All activity
Filter activity
Deselect all
Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Please
register
or
sign in
to reply
Loading