GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Simon Mazenoux requested to merge SIGMON-530_fix_AN_RB_FPA_notebook into dev Oct 23, 2023

Context

Zinur spotted some bugs in the RB_FPA notebook when neither nQPS is dumped nor logs present in NXCALS.

What was done

add some nullity conditions

TODO

fix the second error in 8.3

QA

code was not unit tested, because we can quickly run the notebook to reproduce the issue and make sure the code was actually fixed
acceptance tests were written

Review objectives

code functionality
code quality