Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • lhc-sm-hwc lhc-sm-hwc
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCData
  • lhc-sm-hwclhc-sm-hwc
  • Merge requests
  • !46

Merged
Created Oct 12, 2021 by Aleksandra Mnich@almnichOwner

[SIGMON-198] same env as on SWAN

  • Overview 3
  • Commits 15
  • Pipelines 14
  • Changes 67

Context

  • task: https://its.cern.ch/jira/browse/SIGMON-198
  • lhc-sm-notebook MR:

What was done

  • we need to manually install libjpeg-turbo in the container. (apparently, the headers are not included in the version of pill 'our' matplotlib is using)
  • reference executed notebooks used in acceptance tests updated

TODO

  • documentation (separate task https://its.cern.ch/jira/browse/SIGMON-199)

QA

  • no sonar for notebooks
  • code was not unit tested, because it's lhc-sm-hwc
  • acceptance tests were written (executed notebooks were compared with the previous reference executions)

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: SIGMON-198_same_env_as_on_SWAN