Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • lhc-sm-hwc lhc-sm-hwc
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCData
  • lhc-sm-hwclhc-sm-hwc
  • Merge requests
  • !47

[SIGMON-145] do not crash

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aleksandra Mnich requested to merge SIGMON-145_do_not_crash into dev Oct 18, 2021
  • Overview 4
  • Commits 9
  • Pipelines 4
  • Changes 39

Context

  • task: https://its.cern.ch/jira/browse/SIGMON-145
  • lhc-sm-api MR: lhc-sm-api!96 (merged)
  • lhc-sm-notebook MR: lhc-sm-notebook!8 (merged)

What was done

  • 'safe' version of pandas.loc/get used in the notebooks

TODO

  • ?

QA

  • sonar: http://sonar.cern.ch/project/issues?branch=SIGMON-145_do_not_crash&id=lhc-sm-api&resolved=false
  • code was not unit tested because it's lhc-sm-hwc
  • reference notebooks were reviewed

Review objectives

  • sssessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
Edited Oct 22, 2021 by Aleksandra Mnich
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: SIGMON-145_do_not_crash