Skip to content
Snippets Groups Projects

[SIGMON-145] do not crash

All threads resolved!
Merged Aleksandra Mnich requested to merge SIGMON-145_do_not_crash into dev
All threads resolved!

Context

What was done

  • 'safe' version for pandas.at written

TODO

  • ?

QA

  • no sonar yet (config needs to be pushed to master first)
  • code was unit tested
  • acceptance tests were not written, because there were no new features

Review objectives

  • assessment of code functionality
  • assessment of code quality
  • identifying potential refactorings / logic common to other projects
  • knowledge sharing
Edited by Aleksandra Mnich

Merge request reports

Pipeline #3149631 passed

Pipeline passed for d94baa77 on SIGMON-145_do_not_crash

Merged by Aleksandra MnichAleksandra Mnich 3 years ago (Oct 22, 2021 7:34am UTC)

Loading

Pipeline #3176722 passed

Pipeline passed for d382f41f on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Aleksandra Mnich resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Emanuel Milan Thaller approved this merge request

    approved this merge request

  • Aleksandra Mnich marked this merge request as ready

    marked this merge request as ready

  • Jean-Christophe Garnier approved this merge request

    approved this merge request

  • mentioned in commit d382f41f

  • Please register or sign in to reply
    Loading