Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
lhc-sm-hwc
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Iterations
Wiki
Requirements
Jira
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LHCData
lhc-sm-hwc
Merge requests
!84
[
SIGMON-302
] new AN_RB_FPA
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Aleksandra Mnich
requested to merge
SIGMON-302_new_AN_RB_FPA
into
dev
2 years ago
Overview
4
Commits
27
Pipelines
7
Changes
57
Expand
Context
task:
https://its.cern.ch/jira/browse/SIGMON-302
(but also
https://its.cern.ch/jira/browse/SIGMON-249
and
https://its.cern.ch/jira/browse/SIGMON-2
)
lhc-sm-api
mr:
lhc-sm-api!133 (merged)
What was done
new cells in the AN_RB_FPA (written by Zinur, refactored by me):
statistics for PM and Nxcals sources
plots of the Power Converter Earth Current for RCS, RCO and RCD circuits added
execution of certain cells made conditional
new references generated for the tests
TODO
?
QA
no sonar for
lhc-sm-hwc
notebooks passed:
https://gitlab.cern.ch/LHCData/lhc-sm-hwc/-/jobs/19023167
Review objectives
assessment of code functionality
assessment of code quality
knowledge sharing
Edited
2 years ago
by
Aleksandra Mnich
👍
0
👎
0
Merge request reports
Activity
All activity
Filter activity
Deselect all
Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Please
register
or
sign in
to reply
Loading