Use concrete event data types in Fatras
Adds ActsFatras::Barcode
from the framework and streamlines the existing ActsFatras::Particle
type. Most places that were previously templated on the detector and particle type now use Acts::MaterialProperties
and ActsFatras::Particle
directly. Adds some missing tests as well.
The ActsFatras::Barcode
used a slightly different encoding from the one currently used in the framework. The modifications allow better encoding of secondaries. A detailed explanation is given in the Barcode.hpp
file.
Contains some drive-by fixes and cleanups in preparation of #698 (closed).
Fixes half of #696 (closed).
Merge request reports
Activity
changed milestone to %0.17.00
added Component - Fatras Improvement Major labels
added 17 commits
-
a81fc326...c0d770a3 - 3 commits from branch
master
- 56f0668c - PdgParticle: add invalid value
- 2787888d - Fatras: fix Landau parameter names
- f9f83f8d - Fatras: simplify Landau number generation
- b278f90d - Fatras: add Barcode from framwork
- 1018a5aa - Fatras: streamline particle and add tests
- ff044af9 - Fatras: update particle api in tests
- 1238f9a5 - Fatras: use consistent naming for kinematic casts
- 301ecc39 - Fatras: kinematic casts use Particle
- f06d5621 - Fatras: use Particle for charge selectors, add missing test
- a4cf72e1 - Fatras: use cast directly for selector helpers
- ce28dc1a - Fatras: remove stored value and use Particle in pdg selectors
- 7ae33180 - Fatras: remove X0/L0 limit selectors
- bea743bb - Fatras: use concrete types in energy loss
- 7a2cd684 - Fatras: use concrete types for scattering
Toggle commit list-
a81fc326...c0d770a3 - 3 commits from branch
mentioned in merge request !763 (merged)
added 37 commits
-
7a2cd684...cc517b1e - 21 commits from branch
master
- 5e1fd102 - PdgParticle: add invalid value
- 20d84937 - PdgParticle: use fixed-size underlying type
- eeea648b - Fatras: fix Landau parameter names
- b38124c8 - Fatras: simplify Landau number generation
- 44f68a58 - Fatras: move Landau distribution to utilities
- 683e921a - Fatras: add Barcode from framwork
- af1d979e - Fatras: streamline particle api and add tests
- eb858708 - Fatras: update particle api in tests
- 39a8794c - Fatras: use consistent naming for kinematic casts
- 02c14aa5 - Fatras: kinematic casts use Particle
- 7bd2f33a - Fatras: use Particle for charge selectors, add missing test
- 4d5aea98 - Fatras: use cast directly for selector helpers
- 2259d01d - Fatras: remove stored value and use Particle in pdg selectors
- cb7224b2 - Fatras: use concrete types for limit selectors
- dd15b170 - Fatras: use concrete types in energy loss
- ce2b1284 - Fatras: use concrete types for scattering
Toggle commit list-
7a2cd684...cc517b1e - 21 commits from branch
added 10 commits
- dc628370 - Fatras: add separate ProcessType enum
- 817332cc - Fatras: update particle api in tests
- 019e7bc3 - Fatras: use consistent naming for kinematic casts
- 18e3c93d - Fatras: kinematic casts use Particle
- 8fc32ac7 - Fatras: use Particle for charge selectors, add missing test
- 8c150b4b - Fatras: use cast directly for selector helpers
- 9c17b04d - Fatras: remove stored value and use Particle in pdg selectors
- fe0fb505 - Fatras: use concrete types for limit selectors
- 0990917f - Fatras: use concrete types in energy loss
- c13c6b4f - Fatras: use concrete types for scattering
Toggle commit listadded 10 commits
- c26c37ae - Fatras: add separate ProcessType enum
- e975a93f - Fatras: update particle api in tests
- db036ef0 - Fatras: use consistent naming for kinematic casts
- fd9ff1f4 - Fatras: kinematic casts use Particle
- e63e0cb5 - Fatras: use Particle for charge selectors, add missing test
- c5375355 - Fatras: use cast directly for selector helpers
- 0e463ae4 - Fatras: remove stored value and use Particle in pdg selectors
- c1cd03e3 - Fatras: use concrete types for limit selectors
- 83635546 - Fatras: use concrete types in energy loss
- ab915db8 - Fatras: use concrete types for scattering
Toggle commit list@asalzbur Following the discussion in !763 (merged), the limit selector deletion has been remove from this MR. I also added some more modifications to the imported barcode that are necessary to encode secondaries/tertiaries/... . Do you think you could review this?
assigned to @asalzbur
assigned to @fklimpel
added 23 commits
-
ab915db8...efd9ac3c - 6 commits from branch
master
- 48c22c33 - PdgParticle: add invalid value
- d659ed53 - PdgParticle: use fixed-size underlying type
- 89df3867 - Fatras: fix Landau parameter names
- 9bd24ca8 - Fatras: simplify Landau number generation
- dc252150 - Fatras: move Landau distribution to utilities
- d7dc89e9 - Fatras: add Barcode from framwork
- ded96f3e - Fatras: streamline particle api and add tests
- 7746797f - Fatras: add separate ProcessType enum
- ad17f2b4 - Fatras: update particle api in tests
- cb890059 - Fatras: use consistent naming for kinematic casts
- bf506042 - Fatras: kinematic casts use Particle
- 4f33f138 - Fatras: use Particle for charge selectors, add missing test
- 87899d72 - Fatras: use cast directly for selector helpers
- 83e2689e - Fatras: remove stored value and use Particle in pdg selectors
- ac8c936e - Fatras: use concrete types for limit selectors
- 5ce11d5a - Fatras: use concrete types in energy loss
- 35311d5e - Fatras: use concrete types for scattering
Toggle commit list-
ab915db8...efd9ac3c - 6 commits from branch
- Resolved by Andreas Salzburger
- Resolved by Andreas Salzburger