ACTS-27 cmake options followup
This is the followup MR discussed in !47 (merged).
- OpenMP is on by default, unless you are using OSX.
- Added
add_subdirectory_if
command to simplify handling of optional components. This also prints automatic messages about enabled/disabled components. - Consistently use build flags.
As already discussed in !47 (merged), the build flags are used to selectively include subdirectories instead of manually wrapping large parts of the CMakeLists.txt
in a if()/endif()
statement. There are a few cases where this was not quite possible, e.g. Examples/Fatras
. In the long run, this might be split into Examples/Fatras
which requires Pythia8 and Examples/FatrasDD4hep
which requires Pythia8 and DD4hep.
Merge request reports
Activity
mentioned in merge request !47 (merged)
- Resolved by Moritz Kiehn
- Resolved by Moritz Kiehn
This version looks good to me. @asalzbur, are you fine with this lighter-weight add_subdirectory_if syntax, or would you like to pursue our previous discussion on !47 (merged) regarding this matter?
I am perfectly happy with that, I think the add_subdirectory_if makes it clear right away.
Ok from my side - @hgraslan I think you can accept and merge.
Ok, I figured it out by re-reading the error message. It's just that I'm not one of those who can push to master in this repo, and I would need that permission to merge other peoples' branches. Makes sense.
Edited by Hadrien Benjamin GraslandI tried to change the permissions, but failed - will check with @cgumpert next week
mentioned in commit a21ecf5d