Skip to content

tweak NLHE check for low-stats files

Christian Gutschow requested to merge nlhe_tweak into master

Description of bug

NLHE + 4sigma works nicely for 10k events, but not so well for 10 events, seeing as people tend to put a 10% margin.

10% margin (what people typically require in the JobOptions)

  • 10000 -> 11000
  • 100 -> 110

4sigma check in logParser:

  • 10000 -> 10400
  • 100 -> 140

Note that the 4sigma check is less conservative than the 10% for 10k events (logParser wouldn't complain), but it is more conservative for the 100 events run in the CI (where logParser would cause a crash).

Changes introduced

Change logic to if pass_4sigma or pass_10percent: OK; else crash

Tests

https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/pipelines/2897129

Issues resolved

#149 (closed)

Edited by Spyros Argyropoulos

Merge request reports