Skip to content
Snippets Groups Projects

Exclude renamed files from `check_added_files` checks

Merged Spyros Argyropoulos requested to merge fixaddfiles into master

Description of bug

check_added_files was based on git diff-tree --diff-filter=A where apparently renaming detection is switched off by default so the following would lead to a failed pipeline

Screenshot_2021-11-11_at_19.23.26

Changes introduced

  • Add --find-renames to the git command

Tests

Adding Madgraph.py in a pre-existing DSID directory and renaming the jO that was there I get

Screenshot_2021-11-11_at_19.43.29

which is correct. The renamed file does not show up but the added file does. If the check_modified_files job would run one would also get:

Screenshot_2021-11-11_at_19.45.07

So for a renaming to be successful one should commit with [skip modfiles] (which is what the intended behaviour was from the beginning).

Issues resolved

Closes #

Edited by Spyros Argyropoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading