Introduce default assignees for jobOption MR (assignees directly defined in the MR template)
Fix some mistakes in README and also add email for contact
For email contact I put atlas-phys-mcprod-jo@cern.ch. I suppose that everyone here is a member of that list (if not perhaps subscribe?) so that bug reports, help requests etc come to a single address and can reach all of us.
For any technical issues contact (atlas-phys-mcprod-jo@cern.ch)[mailto:atlas-phys-mcprod-jo@cern.ch]
# Instructions for registering new jobOptions (MC contacts)
Before uploading new jO files to the repository, you need to make sure that you have tested the jO locally with `Gen_tf.py` and have included the `log.generate` produced by `Gen_tf.py` in the DSID directories you want to upload.
@@ -55,14 +59,14 @@ To skip certain CI jobs run the commit script adding the `-m="[skip X],[skip Y]"
**Nota bene: Using the default gitlab rules to skip all pipelines, like `[skip ci]`, has the same effect as a failed pipeline, i.e. it leads to a merge request which cannot be merged according to the new gitlab policy for pipelines!**.
The only way to skip all pipelines is to add `[skip all]` in the commit message, however this is reserved for expert users only and associated MRs will need approval from the PMG conveners.
# Accepting a MR with new jobOptions
# Accepting a MR with new jobOptions (jO coordinators)
Before accepting a MR make sure that all the items below have been completed successfully:
* All the items in the todo list of the MR have been comleted successfully
* All the items in the todo list of the MR have been completed successfully
* The pipeline has run and the status is green
* CI jobs have not been skipped (if jobs have been skipped, confirmation from the PMG conveners is necessary before merging)
* Look at the output of the `run_athena` pipeline and make sure that it has run **for all DSIDS added to the commit**. If it's not the case, confirmation from the PMG conveners is necessary before merging
* CI jobs have not been skipped (if jobs have been skipped, confirmation from the PMG conveners is necessary before merging).
* Look at the output of the `run_athena` pipeline and make sure that it has run for one of the DSIDs added to the commit. If it's not the case, confirmation from the PMG conveners is necessary before merging
* Check that no `log.generate.short` files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
Spyros Argyropoulos authored