Skip to content
Snippets Groups Projects

MG3.5 tllq nominal samples

Merged Dominic Hirschbuehl requested to merge dhirsch_tzq into master

Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.

JIRA ticket

ATLMCPROD-11212

Checklist for approval

This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.

  • I have followed the guidelines in McSampleRequestProcedure
  • I have provided the ATLMCPROD JIRA ticket where the request has been discussed
  • The request has been approved by the PA/CP group
  • The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
  • If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
  • CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
  • Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
  • Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
  • Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block
  • Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.
Edited by Dominic Hirschbuehl

Merge request reports

Merge request pipeline #7404991 passed

Merge request pipeline passed for 869e2bd0

Approved by

Merged by Dominic HirschbuehlDominic Hirschbuehl 10 months ago (May 17, 2024 8:59pm UTC)

Merge details

  • Changes merged into master with bcff5715 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Dominic Hirschbuehl approved this merge request

    approved this merge request

  • added 1 commit

    Compare with previous version

  • ATLAS PMG Service account reset approvals from @dhirsch by pushing to the branch

    reset approvals from @dhirsch by pushing to the branch

  • Dominic Hirschbuehl marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

    marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

  • Dominic Hirschbuehl marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

    marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

  • Dominic Hirschbuehl marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

    marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

  • Dominic Hirschbuehl marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

    marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

  • Dominic Hirschbuehl marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

    marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

  • Dominic Hirschbuehl marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

    marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

  • Dominic Hirschbuehl approved this merge request

    approved this merge request

  • Lucia Keszeghova mentioned in merge request !3647 (merged)

    mentioned in merge request !3647 (merged)

Please register or sign in to reply
Loading