Skip to content
Snippets Groups Projects

JOs for dijet backgrounds for 4b HL-LHC trigger studies

Merged Jason Robert Veatch requested to merge dsid_jveatch_800285 into master

JIRA ticket

ATLMCPROD-8672

Checklist for requesters

  • I have followed the guidelines in McSampleRequestProcedure
  • I have provided the ATLMCPROD JIRA ticket where the request has been discussed
  • The request has been approved by the PA/CP group
  • I have checked the "Squash commits when merge request is accepted" option below
  • I have checked the "Delete source branch when merge request is accepted." option below

Checklist for approvers

  • All the items in the "Checklist for requesters" have been completed successfully
  • The pipeline has run and the status is green
  • CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
  • Look at the output of the run_athena pipeline and make sure that it has run for one of the DSIDs added to the commit. If it's not the case, confirmation from the PMG conveners is necessary before merging
  • Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
  • Check that no file has been modified or deleted
  • Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
  • Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block
  • Check that "Squash commits when merge request is accepted" is selected
Edited by Christian Gutschow

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I am adding the High priority label since the request is very urgent and will be requested with a priority of 0+.

  • Cyril Pascal Becot approved this merge request

    approved this merge request

  • Cyril Pascal Becot marked the checklist item All the items in the "Checklist for requesters" have been completed successfully as completed

    marked the checklist item All the items in the "Checklist for requesters" have been completed successfully as completed

  • Cyril Pascal Becot marked the checklist item The pipeline has run and the status is green as completed

    marked the checklist item The pipeline has run and the status is green as completed

  • Cyril Pascal Becot marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

    marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

  • Cyril Pascal Becot marked the checklist item Look at the output of the run_athena pipeline and make sure that it has run for one of the DSIDs added to the commit. If it's not the case, confirmation from the PMG conveners is necessary before merging as completed

    marked the checklist item Look at the output of the run_athena pipeline and make sure that it has run for one of the DSIDs added to the commit. If it's not the case, confirmation from the PMG conveners is necessary before merging as completed

  • Cyril Pascal Becot marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

    marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

  • Cyril Pascal Becot marked the checklist item Check that no file has been modified or deleted as completed

    marked the checklist item Check that no file has been modified or deleted as completed

  • Cyril Pascal Becot marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

    marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

  • Cyril Pascal Becot marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

    marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

  • Hey @jveatch all the items are checked. Only problem is the rebase doesn't seem to be possible through gitlab's web interface and needs to be done locally. Can you do it ?

  • added 5 commits

    • 2cfff269 - 1 commit from branch master
    • 55946ac4 - New DSIDs for dijet samples for 4b HL-LHC studies
    • 1f1ae83a - Renaming physics short
    • 98676bea - Pipeline for 81b25a38 succeeded. Removing log.generate files [skip all]
    • eeb70991 - Merge branch 'dsid_jveatch_800285' of...

    Compare with previous version

  • Hi @cbecot,

    Ok, hopefully that worked...

    Cheers,

    Jason

  • Christian Gutschow marked the checklist item Check that "Squash commits when merge request is accepted" is selected as completed

    marked the checklist item Check that "Squash commits when merge request is accepted" is selected as completed

  • Christian Gutschow approved this merge request

    approved this merge request

Please register or sign in to reply
Loading