Skip to content

Debuggin session outcome 29.06.2022

Aleksandra Poreba requested to merge aporeba-29-06-22 into master
  • remove dependency on TriggerTool and ass cut calculating functions to LePrescale class
  • fix the validation
  • the validatePrescales function will now return ValidationResult object with request status and new prescale set
  • remove any dependencies on internal L1Prescale in L1PrescaleSaver - object will only work with sets passed by function
  • add validation to L1Prescale set to make sure the map and set are present before reading the cut value
  • save new prescales to a file with "AUTO_" prefix
  • fix ctpid retrieval (ctpid was always increased by 1)
  • increase the verbosity (current logging will be replaced eventually)
  • replace System.out.println with IguiLogger.info
  • remove unused sqlexception

Second commit:

  • improved imports order
  • review the APE constructor arguments
  • spacing fixes and added documentation
  • removed last TriggerTool reference
  • removed TriggerDB from the cmake and comments from starting script
  • ensure deep copy of prescales set in L1Prescale copy constructor
  • minor fixed from the review

Further ideas: add logger class, add separate class to handle IS reading/publishing

@mark

Edited by Aleksandra Poreba

Merge request reports