"aikoulou submitted CTPfragment with tag CTPfragment-01-01-18 for tdaq-common-10-00-00"

=== CTPfragment ===

fix muctpi cand flags (Aimilianos Koulouris)

added Level1 label

assigned to @rhauser and @akazarov

@aikoulou, can we get some more details why this patch is requested only now but the fix is from 7 months ago? CTPfragment!7 (merged)

In principle we cannot simply patch tdaq-common as the entire offline software depends on it. However, in this specific case, we (offline/HLT) don't seem to be using the changed CTPfragment/MuCTPIdataformat_run3.h file.

Where is this actually used?

Hi Frank,

indeed, I think this is mainly used offline when we want to look into RAW data (cc @amarzin).

This was not included earlier by mistake. If there is any concern, i think it's not an issue for us to have it in the nightly for now. Antoine please correct, in case I'm forgetting something.

Emil

I have a feeling that changing in static constants in .h file won't affect anything until one rebuilds the client code, so we need to patch offline version of tdaq-common-10 to get this into any following offline build?

Yes, but if it's not absolutely needed, I'd rather not patch a production tdaq-common.

Can't it live in offline software for now (i.e. this year) ? I assume it's not used by online either since its' new

I close this as it seems this is not needed for tdaq-10-00-00 and the next production release is imminent

closed