'CMakeLists.txt' (PFODQA-00-00-10)

Reconstruction/PFlow/PFlowValidation/PFODQA/CMakeLists.txt

+################################################################################
+# Package: PFODQA
+################################################################################
+
+# Declare the package name:
+atlas_subdir( PFODQA )
+
+# Declare the package's dependencies:
+atlas_depends_on_subdirs( PUBLIC
+                          GaudiKernel
+                          PRIVATE
+                          Control/AthenaMonitoring
+                          Event/xAOD/xAODCaloEvent
+                          Event/xAOD/xAODPFlow
+                          Reconstruction/PFlow/PFlowUtils
+                          Reconstruction/PFlow/PFlowValidation/PFOHistUtils
+                          Tracking/TrkValidation/TrkValHistUtils )
+
+# External dependencies:
+find_package( ROOT COMPONENTS Core Tree MathCore Hist RIO pthread )
+
+# Component(s) in the package:
+atlas_add_component( PFODQA
+                     src/*.cxx
+                     src/components/*.cxx
+                     INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
+                     LINK_LIBRARIES ${ROOT_LIBRARIES} GaudiKernel AthenaMonitoringLib xAODCaloEvent xAODPFlow PFOHistUtils TrkValHistUtils )
+

Reconstruction/PFlow/PFlowValidation/PFODQA/Changelog

+11 May 2015 Mark Hodgkinson
+Fix Coverity issues 17432, 16380	
+Tag as PFODQA-00-00-10
+	
 4 November 2014 Mark Hodgkinson
 Add usage of new PFOAttributes class
 Tag as PFODQA-00-00-09

Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValCluster.cxx

@@ -42,6 +42,7 @@ StatusCode PhysValCluster::fillHistograms(){
 
   if (!theClusterContainer){
     if (msgLvl(MSG::WARNING))  msg(MSG::WARNING) << " Have NULL pointer to xAOD::PFOContainer " << endreq;
+    return StatusCode::SUCCESS;
   }
   
   xAOD::CaloClusterContainer::const_iterator firstCluster = theClusterContainer->begin();

Reconstruction/PFlow/PFlowValidation/PFODQA/src/PhysValPFO.cxx

@@ -59,6 +59,7 @@ StatusCode PhysValPFO::fillHistograms(){
 
   if (!thePFOContainer){
     if (msgLvl(MSG::WARNING))  msg(MSG::WARNING) << " Have NULL pointer to xAOD::PFOContainer " << endreq;
+    return StatusCode::SUCCESS;
   }
   
   xAOD::PFOContainer::const_iterator firstPFO = thePFOContainer->begin();