In 21.2 we never made the block configuration fully agree with the
sequence configuration and we stopped developing it, so I disabled the
corresponding tests.  Leaving the tests commented out since this
branch is on its way out and if somebody tries to investigate what's
going on I want to leave them with a trace of it.

Miha Muskinja authored 1 year ago and Nils Erik Krumnack committed 1 year ago

make 410470 the default also for Pythia8

Miha Muskinja authored 1 year ago and Nils Erik Krumnack committed 1 year ago

latest e/gamma recommendations

Vakhtang Tsulaia authored 2 years ago and Atlas Nightlybuild committed 2 years ago

CP algs: seed MET systematics tool for reproducibility

See merge request !60418

(cherry picked from commit d053d13b)

bb191472 CP algs: seed MET systematics tool for reproducibility

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

make a configuration block for event cleaning

See merge request !59010

(cherry picked from commit d50bb4a8)

122bbb9d make a configuration block for event cleaning

Frank Winklmeier authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Substitute period with p for run2 trigger decos

See merge request !58555

(cherry picked from commit f562ccd3)

81970abf Substitute period with p for run2 trigger decos
128cc46c Substitute period with p for run2 trigger decos
2b2caaf4 Merge branch 'Substitute-trigger-decorators-run2' of...
777d7ceb Remove white spaces (formatting)

Some minor changes and disabling some code, just to make everything
work now.

If I want to do everything via blocks, this is one I need.

This is still very basic, but so is the sequence version.

That will be needed for most actual jobs, so it is good to have.

Allow setting container selections directly in the MET maker

This now makes most algorithms work on PHYSLITE, and the ones that do
not work can be turned off.

This adds some tweaks to improve the performance of the sequence, some
extra variables commonly used, and allow running trigger selection
without filtering.

This is now hopefully more straightforward than it was, and should
allow future refactoring as needed.

This is mostly a transcribing of the electron sequence in the style of
the muon configuration block.

These are based closely on the ones for the electrons, with the code
from the current photon sequences.

Those were already there, just needed to be updated.

Mostly based on what I did for the leptons and the existing jet
sequences.

This removes all the implicit views created by the various sequences,
and instead creates explicit views as inputs for MET and OR.  And it
adds actual consistent thinning for all containers for the output.
And it adds pt/eta cuts for all the objects, which are probably way
off from what they should be...

I also had to add some extra configuration options/decorations to some
of the sequences to make it all consistent.

This is mostly a collection of all the algorithms tests from the
various CP algorithm packages loosely stitched together.  It probably
will need some more cleanup at some point, but it at least provides a
baseline to test the configuration blocks against as I develop them.

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Properly apply pt cut in analysis sequences

See merge request !57419

(cherry picked from commit 90677e35)

dd72cb76 Properly apply pt cut in analysis sequences

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

CP algs: Only use efficiency SFs in case of Continuous FTag WP

See merge request !57420

(cherry picked from commit 87fcb6c4)

e8778b94 Only use efficiency SFs in case of Continuous FTag WP

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

allow disabling systematics for EgammaCalibrationAndSmearingAlg (for ATLASG-2358)

See merge request !57320

(cherry picked from commit 3ce6fa19)

5cc968e5 allow disabling systematics for EgammaCalibrationAndSmearingAlg (for ATLASG-2358)

Johannes Elmsheuser authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Correctly initialize the SysFilterReporterParams

See merge request !56223

(cherry picked from commit 6a853292)

4ee7c820 Correctly initialize the SysFilterReporterParams

This goes back to an old discussion that in principle AsgSelectionAlg
should not have a SysCopyHandle, as it doesn't introduce new momentum
systematics.  The reason it has one currently is that if there is a
selection before the correction algorithm it does need to make a
shallow copy that can then subsequently be modified at will.

The solution implemented here is what we discussed back then: To
implement an algorithm that does nothing more than make a shallow copy
(based on the view container algorithm and the copy mechanism from
SysCopyHandle) and schedule that before AsgSelectionAlg as needed.

CP Algorithms: global comparison of block configuration and sequences

See merge request !55729

(cherry picked from commit 5f1e590d)

520769f2 CP Algorithms: global comparison of block configuration and sequences

Given that the first iteration of the configuration block design
invoked criticism of the "reference" design for tracking containers I
now changed it, so that instead of first allocating references to
determine what the intermediate containers are, I just run through the
entire configuration twice.  The second run-through then can rely on
what it learned in the first run-through to determine what will happen
further down in the sequence.

This requires routing a number of calls through the ConfigAccumulator
object, but it definitely makes writing the actual blocks more
straightforward, and it should also allow for more flexibility if we
need to redesign the ConfigAccumulator in the future (which also
became simpler with this change).

Nils Krumnack authored 2 years ago and Nils Erik Krumnack committed 2 years ago

This allows testing that software works on DAOD_PHYS.

I'm keeping the old files around with the suffix _OLD, as users have
specifically requested to be able to keep tests on older files which
may require different tool settings.

I also updated a fair number of the CP algorithm tests so that they
now explicitly use the _OLD files until issues are resolved.

Ahmed Tarek authored 2 years ago and Nils Erik Krumnack committed 2 years ago

Merge branch 'Defaultflags_2022' into 'LayerCorrection_21.2'

editing default flags for es2022_R21_Precision

See merge request ATLAS-EGamma/athena!29

(cherry picked from commit 347bb964)

7fcbb58d editing default flags for es2022_R21_Precision
9d4b82f6 typo
a5d45a2e ElectronAnalysisSequence change

Ahmed Tarek authored 2 years ago and Nils Erik Krumnack committed 2 years ago

adding new Layer intercalibration histogram and preparing ElectronPhotonFourMomentumCorrection for new Sys

Tadej Novak authored 2 years ago and Atlas Nightlybuild committed 2 years ago

Add a const getCopy method to the SysCopyHandle and use it in the AsgSelectionAlg

See merge request !54929

(cherry picked from commit 00c75bef)

7a033d23 Add a const getCopy method to the SysCopyHandle and use it in the AsgSelectionAlg

This breaks on our test files which don't have the right input
variables.  We should probably reactivate this once we switch to
DAOD_PHYS input files.