GitLab

Not sure if those indicated that something broke or not, but this
should fix things (at least it does for me locally).

On request of @jburr to make this easier to understand and teach for
beginners.  Note that this involved a fair amount of whitespace
changes to make the for-body indentation consistent with the rest of
each file.

SysListDumperAlg, fix clang compilation error:  decltype(auto) cannot be combined with other type specifiers

Essentially when we are using a decoration handle we should not need
to make a copy, but be able to directly decorate the input object.

There are probably other common CP algorithms that could be switched
from `SysCopyHandle` to `SysReadHandle`, but this is the lowest
hanging fruit.

These essentially just test that the handles compile.  That was a
concern when first developing them, but by now there are enough users
that it doesn't really provide any benefit (but breaks things).

SystematicsHandles gcc11 warnings follow-up

See merge request !45545

(cherry picked from commit e7e8298a)

4af7cdd4 SystematicsHandles gcc11 warnings

SystematicsHandles gcc11 warnings

See merge request !45474

(cherry picked from commit c55731c9)

ec5b5223 SystematicsHandles,SystematicsHandles gcc11 warnings

The ultimate goal here is to have the python configurable no longer
inherit from the C++ object, and instead create the C++ object only at
the moment when it is needed, instead of having it as a base class and
performing all updates simultaneously to the python object and the C++
object (to keep them in sync).  However, for now it mostly adds an
alternate way of adding algorithms to jobs, to actually make the more
fundamental change to the configurables would require all users to
update to the new formalism of adding algorithms to jobs.

This also allows additional configurable objects to be used, e.g. I
now treat algorithm sequences and algorithms the same.

This could potentially also be used to change the target or mechanism
of configuration at some point, e.g. to push this into an intermediate
JSON file, but that's not an immediate goal.

For now this just replaces the algorithm with a service, and
communicates the systematics list via the service interface instead of
via the event store.

The plan is to add more functionality in future merge requests that
will move a lot of the systematics handling functionality from the
configuration layer into the service.

Mostly so that it acts as a test of whether the EventLoop python
configuration would work properly on the grid.

As agreed in the analysis release meeting the specific goal here is
just to disable all the warnings that have existed in 21.2 for a long
time and that lead to occasional confusion during the merge reviews.
In a few cases I tried to address the actual source of the warning,
but for the most part I just picked the most expedient way to shut it
off, instead of trying to determine whether they point to an actual
problem or not, and then fixing them accordingly.

Adds AsgElectronSelectorTool (adapted from AsgElectronLikelihoodTool)
which retrieves variables and does some basic checks whether the object
is an electron etc. The TElectronSelectorTool applies all cuts placed
on variables including the DNN score. The DNN score is calculated in
the ElectronDNNTool using lwtnn. The ElectronSelectorTool is the parent
class of the ElectronDNNTool and enables to include other MVA methods
at a later point such as a CNN.

AsgAnalysisAlgorithms: Missing preExecute call.

See merge request !39758

(cherry picked from commit 97f2c703)

b6c81cf9 AsgAnalysisAlgorithms: Missing preExecute call.

SelectionHelpers: Fix use of dangling reference.

See merge request !39051

(cherry picked from commit 946bac9e)

126e53e3 SelectionHelpers: Fix use of dangling reference.

AsgCutBookkeepersAlg: fix compilation warnings

See merge request !37619

(cherry picked from commit 2ef630ae)

7f348205 AsgCutBookkeepersAlg: fix compilation warnings

This is needed to make them work in the presence of the issues described in
https://sft.its.cern.ch/jira/browse/ROOT-10940.

The list of isolation WPs is taken from
https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/AnalysisCommon/IsolationSelection/Root/IsolationSelectionTool.cxx#L175

Add optional names

Fix isolation in makeMuonAnalysisSequence tests

Use NonIso for muon CP alg tests

created.

The tool will not work in this commit because I have to change the
function "applycorrection" to use an object "jet" and not a pointer. We
will be working on this in the next commit.

After !31568, this seems to be mandatory, but this algorithm was not
updated to do it. This MR adds the initialize call.

Not sure I got it completely correct, there was some more extensive
logic in here, but at least the tests work out.