Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20296

Large merge to import TrigInDetAnalysis changes from final 21.1-dev to 21.3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Sutton requested to merge sutt/athena:21.3-initn into 21.3 Jan 11, 2019
  • Overview 4
  • Commits 3
  • Pipelines 1
  • Changes 66

Includes the merge of code from last version of 21.1-dev to 21.3, includes update and tidy of the copyright statement ( 2018 -> 2019 etc since these are different between the code in any case)

Their are also some code compliance changes - replacing __FILENAME_H with PACKAGE_FILENAME_H in the include guard and so on

Add the header required for matching the full trigger objects with the tracks needed for the full object selection

The functionality changes (ie changes to code structure) are coming from 21.1-dev / 21.1 so in principle they have been reviewed and validated already, so really reviewing this merge request will be a major waste of time for all concerned.

As it is so large, there might inevitably be some code compliance issues that have been missed, but rather than waste additional time here, these can be addressed in subsequent merge requests over the comming weeks while we try to tidy up and consolidate the changes required by the migration to the new branches

This is further discussed in ATR-19009 which these changes partly address.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.3-initn