Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 146
    • Merge requests 146
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !20468

Update packages:TrigTauRec from upstream/21.0-TrigMC to upstream/master via pseudo-merge

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Bertrand Martin Dit Latour requested to merge martindl/athena:martindl_20_Jan_TrigTauRec_to_master into master Jan 20, 2019
  • Overview 37
  • Commits 1
  • Pipelines 1
  • Changes 6

Hello,

With this MR, we migrate developments that were made in TrigTauRec 21.1 but were never ported to master. Other packages listed in ATR-19015 will follow.

For TrigTauRecMerged.h and TrigTauRecMerged.cxx, we were missing:

  • the monitoring of RNN ID input variables (which is now commented out in master, because the tauRecTools RNN tools have not been migrated to master yet, they will be shortly)
  • the fix to element links (relevant for data)

For TrigTauRecMergedMT.cxx, I only fixed the indentation, and made no other change. Importing the RNN monitoring functionality will be done later (unless this is migrated to tauRecTools somehow?).

For TrigTauAlgorithmsHolder.py and TrigTauRecConfig.py, we were missing all 2018 developments (mediumRNN_tracktwoMVA triggers).

For TrigTauRecMonitoring.py, these are trivial changes.

Cheers, Bertrand

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: martindl_20_Jan_TrigTauRec_to_master