JVT analysis sequence updates

This MR makes JVT efficiency tool return systematics according to the configuration - either JVT or fJVT. @maklein, @fungaro let me know if you have any objections.

fJVT is now supported in the JvtEfficiencyAlg. JVT/fJVT selection is disabled by default as one requires inefficiency scale factors to be stored.

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• Reconstruction/Jet/JetJvtEfficiency

Adding @krumnack as watcher

added 21.2 Analysis JetEtmiss Reconstruction review-pending-level-1 labels

CI Result SUCCESS

	AnalysisBase	AnalysisTop	AthAnalysis	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20861-2019-02-03-19-31
AnalysisBase: number of compilation errors 0, warnings 9
AnalysisTop: number of compilation errors 0, warnings 9
AthAnalysis: number of compilation errors 0, warnings 10
AthDerivation: number of compilation errors 0, warnings 54
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33226]

mentioned in merge request !20824 (merged)

Lets hold off until !20824 (merged) is merged.

added review-user-action-required label and removed review-pending-level-1 label

mentioned in merge request !20282 (merged)

resolved all discussions

added review-approved label and removed review-user-action-required label

This looks good to me as well, and since !20824 (merged) is merged in I think this can be too.

Best, Christian

Hi @cohm, will try to rebase and test it asap.

added 107 commits

• 14ae59e2...8fa6123d - 105 commits from branch atlas:21.2
• 20d5ef35 - Properly return affected JVT/fJVT systematics
• fe019953 - JVT efficiency updates

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• Reconstruction/Jet/JetJvtEfficiency

Adding @krumnack as watcher

added review-pending-level-1 label and removed review-approved label

I rebased and removed the ability to do the JVT selection at this stage. A follow-up for this is located in !20282 (merged).

CI Result SUCCESS

	AnalysisBase	AnalysisTop	AthAnalysis	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20861-2019-02-06-10-26
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33400]

Changes and CI look fine from my point of view. Approving.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 4c1a44db

merged