Update to electron PromptLepton tagger in AT

Simply provide more documentation about the use of the PLI/PLV taggers for electrons, and update corresponding DxAOD decorations to be read. The retrieval of the actual BDT weights is still up to the user, through an AT CustomEventSaver.

Closes ANALYSISTO-484.

This merge request affects 1 package:

• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Adding @smergelm ,@pjacka ,@mvanadia ,@tdado as watchers

added Analysis review-pending-level-1 labels

CI Result SUCCESS

	AnalysisBase	AnalysisTop	AthAnalysis	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21033-2019-02-11-19-29
AnalysisBase: number of compilation errors 0, warnings 9
AnalysisTop: number of compilation errors 0, warnings 9
AthAnalysis: number of compilation errors 0, warnings 10
AthDerivation: number of compilation errors 0, warnings 54
For experts only: Jenkins output [CI-MERGE-REQUEST 33628]

Hi @ravinab,

Your description mentions added doc and reading decorations, but you've also removed a line setting the AnalysisTop_Isol_PromptLepton decoration. Is that intentional?

Apart from that, since this is AnalysisTop I think I'm obliged to make sure @pjacka and @tdado are onboard with this.

Best, Christian

Hi @cohm,

Since there are now 2 BDTs available, I changed the old decoration name (AnalysisTop_Isol_PromptLepton) to reflect that. Furthermore, that particular line wasn't retrieving the correct decoration anymore.

Edit: I should add that both the old and new AnalysisTop_Isol_PromptLepton are not currently used anywhere else in the code.

Hi @ravinab,

the changes are fine with me. Just make sure that this is documented in TopxAODStartGuideR21 twiki page.

It is always good to mention the jira ticket related with an update in the MR description.

Cheers, Petr

changed the description

Thanks guys - approving obo L1 then!

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7c2acc44

added sweep:ignore label