Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 163
    • Merge requests 163
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !21097

fix __call__ for AthConfigFlags

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jovan Mitrevski requested to merge jmitrevs/athena:master-AthConfigFlagsCall into master Feb 13, 2019
  • Overview 7
  • Commits 1
  • Pipelines 1
  • Changes 1

This fixes the call function to use _get instead of get. It was something that was missed when get was renamed.

One thing to discuss is if we instead want to remove the call function altogether. I think it is still useful to have a way to access flags with a string, so tend to vote that it's useful to keep.

Tagging @tbold and @wlampl.

Edited Feb 13, 2019 by Jovan Mitrevski
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-AthConfigFlagsCall