Fixes for trigger monitoring in athenaMT

Frank Winklmeierrequested to merge
fwinkl/athena:trigmon_cleanup into master

We have two defineHistogram methods currently in the repository. The new one in AthenaMonitoring and the legacy one in TrigMonitorBase. New code written for athenaMT should only be using the first method. We had two cases where this was not done consistently and caused problems when a new feature got added to AtheanMonitoring.defineHistogram in !22545 (merged).

TrigL2MuonSA

Use the GenericMonitoringTool.defineHistgram() to define the histograms for athenaMT to avoid any confusion between the old trigger-specific defineHistogram method and the new one.

TrigEFMissingET

Use a helper function to create a fully configured instance of the monitoring tool and use it instead of hard-coding the histograms in multiple places. Also remove the histograms that are currently not even created in the MT-version of the MET algorithm and make sure to use the new version of defineHistogram from AthenaMonitoring. cc @ggallard @khamano

Edited by Frank Winklmeier

Merge request reports