Code cleanup of SiSpacePointsSeedTool_xk package (ATLASRECTS-3037)

Code cleanup of SiSpacePointsSeedTool_xk package

• Define enums to remove magic numbers.
• Use constexpr.
• Use object vectors instead of pointer arrays.
• Avoid new and delete.
• Use default destructor.

The corresponding changes for SiSpacePointsSeedMaker_ATLxk will be done by MR !23244 (merged).

This is followup of MR !23186 (merged).

This merge request affects 1 package:

• InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk

added InnerDetector master review-pending-level-1 labels

changed the description

changed the description

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23240-2019-05-07-22-49
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38135]

Seems fine, thanks, approving.....

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

Thanks for the cleanup, looks nice.

• Walter

merged

mentioned in commit cb677639

added sweep:ignore label

changed title from Code cleanup of SiSpacePointsSeedTool_xk package to Code cleanup of SiSpacePointsSeedTool_xk package (ATLASRECTS-3037)