2D cell-level reweighting of egamma objects
Implemented code by Mykola Khandoga (after cleanup/indentation/variable renaming/..) for 2D cell-level reweighting.
Original code here: https://gitlab.cern.ch/mykhando/athena/tree/rew
Also made a lot of cleanup, added comments, simplified code, removed useless parts, moved from iostream to Athena messages, renamed class members to match ATLAS guidelines
Merge request reports
Activity
added 21.2 Derivation Egamma labels
Hey perhaps not too relevant comments
-
Are we sure on the root files in git ? I have the impression that in general we want to avoid binaries in the repo. I know these are small but they will prb need to be updated and git never forgets .
-
Another point as I learned that was asked today. And this is completely irrelevant in some sense. There is no track-matching recalculated , neither was before. This runs the calorimeter shower shapes. To do track matching and possibly check changes in matching (possible) , needs additional effort ... as these are not final shapes but what actually defines the object per se. Was done once in 2011-2012 and was not easy ...
-
Hello All,
thanks Christos for the comment. In particular for the root file in the repo. I think this is not very good. We can probably easy switch to calibpath ? we do have the old file here :
/eos/atlas/atlascerngroupdisk/asg-calib/DerivationFrameworkCalo/CellReweight_v1
so in principle we just need to copy in a new dir called :
/eos/atlas/atlascerngroupdisk/asg-calib/DerivationFrameworkCalo/CellReweight_v2d
the new root files ( I can do it in principle I should have right access to eos otherwise we ask @psommer )
and modify this line with the correct path in the current implementation: https://gitlab.cern.ch/gmarchio/athena/blob/21.2-EGAMX-CellReweighting2D-20190602/PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo/src/CellReweight.cxx#L59
Edited by Ludovica Aperio BellaHi @ludovica, you need to set the permissions correctly. I made this change to my local code but jobs are failing due to
Error in TFile::TFile: no read permission
Hi Giovanni right, I did something wrong :( discussion in here: https://its.cern.ch/jira/browse/ATLINFR-3075
added 1 commit
- 7320485a - disabled min/max variations for cell-level reweighting for the time being
added 1 commit
- 084fffd2 - added some comments to code and implemented option to turn on/off persisting...
added 1 commit
- 3f7603ce - added some comments to code and implemented option to turn on/off persisting...
added 1 commit
- 7b969c23 - avoid storing twice the same information (as decoration and new container) in EGAM1