use BeamSpotData instead of BeamSpotSvc in egammaTrkRefitter : ATLASRECTS-5016

We need to move away from services to conditions data.

• egammaTrkRefitter should now retrieve the relevant BeamSpot ConditionData where applicable
• Since one needs the EventContext to retrieve them, lets pass it to the this tools.
• This means we also need to update the interface
• And the clients so as to pass it.

Since we are here lets also removed an unneeded dynamic_cast and use a bit more the Athena macros.

Mentioning @amorley (original author of the tool)

This merge request affects 4 packages:

• InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaInterfaces
• Reconstruction/egamma/egammaTrackTools

added Egamma InnerDetector Reconstruction master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24569-2019-07-02-05-47
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 791]

added review-user-action-required label

added 1 commit

• 5d96353e - add isValid check

Compare with previous version

This merge request affects 4 packages:

• InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaInterfaces
• Reconstruction/egamma/egammaTrackTools

removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24569-2019-07-02-23-02
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 811]

The discussion should be resolved before this can be approved. Ruchi (L1)

resolved all discussions

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 147062eb

added sweep:ignore label

mentioned in merge request !23624 (closed)