TrigBphysHypo: Python cleanup

Make python code flake8 compliant and introduce unit test. Applied minimal fixes to trigger legacy code. Some bigger cleanup in the Run-3 trigger code.

Trigger/TrigHypothesis/TrigBphysHypo/python/TrigBphysElectronCounterConfig.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 
 # include the python fragment to set up the default bphysics vertex fitter
-from TrigBphysHypo import TrigBphysVertexingConfig
+from TrigBphysHypo import TrigBphysVertexingConfig  # noqa: F401
 
 from TrigBphysHypo.TrigBphysHypoConf import TrigBphysElectronCounter
 
-from AthenaCommon.AppMgr import ToolSvc
-
 from TrigTimeMonitor.TrigTimeHistToolConfig import TrigTimeHistToolConfig
 from TrigBphysHypo.TrigBphysElectronCounterMonitoring import TrigBphysElectronCounterValidationMonitoring
 from TrigBphysHypo.TrigBphysElectronCounterMonitoring import TrigBphysElectronCounterOnlineMonitoring
@@ -45,7 +43,7 @@ class TrigBphysElectronCounter_bNe (TrigBphysElectronCounterPy):
 
         # set up PID - defined in TrigHypothesis/TrigEgammaHypo/python/TrigEgammaPidTools
         from TrigEgammaHypo.TrigEgammaPidTools import (ElectronToolName,BLooseISEMBits)
-        if pidKey == None or not pidKey in ElectronToolName.keys() or not pidKey in BLooseISEMBits.keys() :
+        if pidKey is None or pidKey not in ElectronToolName.keys() or pidKey not in BLooseISEMBits.keys() :
             log.info(" Setting up bphys electron chain with no electron PID requirement")
             self.ApplyIsEM = False
         else :        
@@ -74,7 +72,7 @@ class TrigBphysElectronCounter_bBee (TrigBphysElectronCounterPy):
 
         # set up PID - defined in TrigHypothesis/TrigEgammaHypo/python/TrigEgammaPidTools
         from TrigEgammaHypo.TrigEgammaPidTools import (ElectronToolName,BLooseISEMBits,ElectronIsEMBits)
-        if pidKey == None or not pidKey in ElectronToolName.keys()  :
+        if pidKey is None or pidKey not in ElectronToolName.keys()  :
             log.info(" Setting up bphys electron chain with no electron PID requirement")
             self.ApplyIsEM = False
         else :