Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 124
    • Merge requests 124
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27301

Fix ART failure in PhotonVertexSelectionTool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Davide Pietro Mungo requested to merge mungo/athena:fix_MR26774_ART_issue into 21.2 Oct 18, 2019
  • Overview 15
  • Commits 5
  • Pipelines 3
  • Changes 5

During the approval discussion of !26774 (merged), some WARNING messages have been changed to ERROR. This MR reverts some of these changes. The reason is the StatusCode::Failure in getVertex function are handled in the overridden getVertex function, accessible from the interface. Therefore returning a StatusCode::Failure with a WARNING should not be a problem. The problem was found during ART test, since the function returns Success but with an ERROR message

Meanwhile, I've reduced the verbosity of the tool, mainly when run to produce unskimmed sample

Tagging: @boeriu @gamerz

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_MR26774_ART_issue