Skip to content

Externals (and Build) Update, master branch (2019.12.09.)

Attila Krasznahorkay requested to merge akraszna/athena:ExternalsUpdate-master-20191209 into master

This is already my 3rd try at this, after !28428 (merged) and !28548 (merged)... 😦

This is to update all projects to atlasexternals-2.0.48, and to make the build of externals in Gaudi based projects more robust.

The updates in atlasexternals-2.0.48 are (atlasexternals@2.0.45...2.0.48):

  • Added a thread safety fix/patch to the FastJet build (thanks to @ssnyder);
  • Updated CheckerGccPlugins with some new features (thanks to @ssnyder);
  • Added a missing "entrypoints" dependency to PyModules (thanks to @fwinkl);
  • Fixed the usage of atlas_export_sanitizer.cmake.in inside of the external projects themselves;
  • Added some missing find-modules for the successful "from scratch" installation of flake8 (thanks to @fwinkl).

The last-but-one update goes hand-in-hand with the updates that this MR makes in Athena/build_externals.sh and AthSimulation/build_externals.sh. In the current implementation when a build error happens in AthenaExternals or AthSimulationExternals, the build scripts exit early, and don't even try to build Gaudi. Which is definitely not what we want in the nightly. So the script updates (in nightly mode) make sure that the build_externals.sh scripts would try to "do everything", whatever happens.

This is to fix the Python 3 and LCG nightlies, which are experiencing issues compiling CheckerGccPlugins at the moment. (See ATLINFR-3221 for some of the details.)

Merge request reports