Skip to content
Snippets Groups Projects

add TTree support for DQ algorithms

Merged Peter Onyisi requested to merge ponyisi/athena:master-dq-add-ttree-support into master
All threads resolved!

Addresses ATLASDQ-665 (adds TTree support to AthenaMonitoringKernel). WIP until !29214 (merged) is merged as there are a couple of minor tweaks to adjust to the updated API.

User interface specifies TTree branches using the new "treeDef" argument of the new defineTree. All the standard TTree primitive types (except for C = C null-terminated string) are supported, as is "string" and a number of vector types (float, double, char, int, long, and the unsigned versions of the integer types).

Cherry-picks a commit from !29191 (merged) (for proper MT operation).

Attn @cburton , @tbold , @fwinkl , @mspalla , @pavol

Edited by Peter Onyisi

Merge request reports

Pipeline #1364186 passed

Pipeline passed for 2b5c37b3 on ponyisi:master-dq-add-ttree-support

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 5 years ago (Jan 27, 2020 12:33pm UTC)

Merge details

  • Changes merged into master with 9eb9826f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Glad to see it actually. It may be way more efficient sometimes to produce trees than the histograms. Online, though we do not have transport layer for that kind of data. I wonder if we ever had any use-case for which it would be helpful. Re-tagging @fwinkl on this.

  • Peter Onyisi added 676 commits

    added 676 commits

    Compare with previous version

  • Peter Onyisi unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Peter Onyisi resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • Control/AthenaMonitoring
    • Control/AthenaMonitoringKernel

    Adding @ssnyder as watcher

  • Peter Onyisi resolved all threads

    resolved all threads

  • :negative_squared_cross_mark: CI Result FAILURE (hash f75f7e07)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8409]

  • Hey @ponyisi

    your unit test is failing. Could you please investigate?

    Thanks, Kira (L1)

  • Peter Onyisi added 1 commit

    added 1 commit

    Compare with previous version

  • Peter Onyisi added 452 commits

    added 452 commits

    Compare with previous version

  • Peter Onyisi changed the description

    changed the description

  • This merge request affects 2 packages:

    • Control/AthenaMonitoring
    • Control/AthenaMonitoringKernel

    Adding @ssnyder as watcher

  • Jenkins please retry a build

  • :white_check_mark: CI Result SUCCESS (hash 2b5c37b3)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8575]

  • Looks OK, approving.

    Tadej (L2)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 9eb9826f

  • Please register or sign in to reply
    Loading