Skip to content

Updates for Trigger CI

Rafal Bielski requested to merge rbielski/athena:updates-for-Trigger-CI into master

Several updates required for new Trigger CI configuration. The main motivation is phasing out of the TrigUpgradeTest package (ATR-20514) and the need for better test coverage as discussed in ATR-19383. This MR has to go in according to the deployment plan outlined below.

Changes in this MR:

  • Add new test test_trig_data_v1MC_build/grid in TriggerTest running athena on data with MC_pp_run3_v1 menu
  • Make RegTest (reference log comparison) a required step for test_trig_data_v1Dev_build (replacement for the trigUpgr_full_menu test)
  • Add fpeAuditor and forceEnableAllChains modifiers to test_trig_data_v1Dev_build to make it identical to the TUT test it replaces
  • Rename "FullMenu" tests in TrigP1Test to "v1Dev" and make them explicitly use the Dev_pp_run3_v1 menu (aka LS2_v1)
  • Remove obsolete test_trigP1_FullMenu_ROSRate (related to the above change)
  • Add a newJO test in TriggerTest, a replacement of the corresponding TrigUpgradeTest test
  • Prevent infinite loop in LogMerge discovered when implementing the above
  • Remove extra post-exec steps from the RDOtoRDOTrig_mt1 test as they take too long for CI and aren't fully adapted to the new trigger framework
  • Change the minimal set of tests executed with runTrigART.py -m to reflect what runs in CI
  • Update references - to be repeated in the deployment stage, see below

Deployment strategy

  1. Merge !30690 (merged) (affects log comparison done in CI)
  2. Rebase and update this MR
  3. Add the new CI scripts from https://gitlab.cern.ch/atlas-sit/CI/merge_requests/129 as optional tests.
  4. Run CI for this MR and check the optional test results, ignoring the fact that the old required ones fail.
  5. Run CI for any MR in 21.0, 21.1, 21.3 just to make sure they are fine also there.
  6. If all the new optional CI tests succeed, merge this MR
  7. Remove the old CI configuration and make the new configuration from https://gitlab.cern.ch/atlas-sit/CI/merge_requests/129 required.
  8. Update atlassoftwaredocs Trigger guide
  9. Announce the change to atlas-trigger-developers mailing list

New Trigger CI configuration

This was agreed in ATR-19383

1. Run athena on data

master_Athena:
    test_trig_data_v7Primaries_build.py
    test_trig_data_v1Dev_build.py - requires reference match in CI
    test_trig_data_v1MC_build.py
    test_trig_data_newJO_build.py
21.3_Athena:
    test_data_physics_pp_v8_build.sh
21.0_Athena:
    test_data_physics_pp_v7_build.sh

2. Run athena on MC

master_Athena:
    test_trig_mc_v7Primaries_build.py
    test_trigAna_RDOtoRDOTrig_mt1_build.py - requires reference match in CI
21.3_Athena:
    test_mc_pp_v7_build.sh
    test_mc_pp_v8_build.sh
21.1_AthenaP1:
    test_mc_pp_v7_build.sh
21.0_Athena:
    test_mc_pp_v7_build.sh

3. Run athenaHLT on data

master_Athena:
    test_trigP1_v1Dev_build.py
    test_trigP1_v1PhysP1_build.py
21.3_Athena:
    test_HLT_mcV8_build.sh
21.1_AthenaP1:
    test_HLT_mcV7_build.sh

Tagging @hartj, @jpanduro, @fwinkl, @smh, @tbold

Edited by Rafal Bielski

Merge request reports